Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbbLGIds (ORCPT ); Mon, 7 Dec 2015 03:33:48 -0500 Received: from mga03.intel.com ([134.134.136.65]:58067 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753102AbbLGIdr (ORCPT ); Mon, 7 Dec 2015 03:33:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,393,1444719600"; d="scan'208";a="868152138" From: Jani Nikula To: Zhaoxiu Zeng , daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Zeng Zhaoxiu Subject: Re: [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])" In-Reply-To: <1449397590-14292-1-git-send-email-zhaoxiu.zeng@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1449397590-14292-1-git-send-email-zhaoxiu.zeng@gmail.com> User-Agent: Notmuch/0.20.2+101~gb57168b (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 07 Dec 2015 10:33:43 +0200 Message-ID: <87h9juzmhk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 48 On Sun, 06 Dec 2015, Zhaoxiu Zeng wrote: > From: Zeng Zhaoxiu > > Signed-off-by: Zeng Zhaoxiu I'd like to see a commit message describing what is done and why, even for trivial changes. Now the subject line is essentially the diff in plain English, which adds no information to the patch itself. It doesn't even say that this should be a non-functional change. BR, Jani. > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 9461a23..16c8cf1 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -27,6 +27,7 @@ > * > */ > > +#include > #include > #include "i915_drv.h" > #include > @@ -1000,7 +1001,7 @@ static int skl_tune_iz_hashing(struct intel_engine_cs *ring) > * Only consider slices where one, and only one, subslice has 7 > * EUs > */ > - if (hweight8(dev_priv->info.subslice_7eu[i]) != 1) > + if (!is_power_of_2(dev_priv->info.subslice_7eu[i])) > continue; > > /* -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/