Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754317AbbLGIiE (ORCPT ); Mon, 7 Dec 2015 03:38:04 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:44113 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753596AbbLGIiB (ORCPT ); Mon, 7 Dec 2015 03:38:01 -0500 Subject: Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage To: David Miller References: <1449300749-50275-1-git-send-email-yankejian@huawei.com> <20151206.222929.804694720513782203.davem@davemloft.net> CC: , , , , , , , , , , From: "Yankejian (Hackim Yim)" Message-ID: <56654552.6030105@huawei.com> Date: Mon, 7 Dec 2015 16:37:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151206.222929.804694720513782203.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.126.191] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.56654562.0028,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 59a46bdfd626d3ab5c3ba9f4708e032e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 30 On 2015/12/7 11:29, David Miller wrote: > From: yankejian > Date: Sat, 5 Dec 2015 15:32:29 +0800 > >> +#if (PAGE_SIZE < 8192) >> + if (hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048) { >> + truesize = hnae_buf_size(ring); >> + } else { >> + truesize = ALIGN(size, L1_CACHE_BYTES); >> + last_offset = hnae_page_size(ring) - hnae_buf_size(ring); >> + } >> + >> +#else >> + truesize = ALIGN(size, L1_CACHE_BYTES); >> + last_offset = hnae_page_size(ring) - hnae_buf_size(ring); >> +#endif > This is not indented properly, and it looks terrible. > > . > Hi David, Thanks for pointing it out. i will pay attention next time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/