Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755087AbbLGI4k (ORCPT ); Mon, 7 Dec 2015 03:56:40 -0500 Received: from mga14.intel.com ([192.55.52.115]:3717 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755020AbbLGI4i (ORCPT ); Mon, 7 Dec 2015 03:56:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,394,1444719600"; d="scan'208";a="701640185" Date: Mon, 7 Dec 2015 10:56:26 +0200 From: Jarkko Sakkinen To: "Wilck, Martin" Cc: Jason Gunthorpe , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Message-ID: <20151207085626.GA15567@intel.com> References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> <20151201213351.GC5071@intel.com> <20151202182726.GB30972@obsidianresearch.com> <20151202191155.GA2832@obsidianresearch.com> <20151203060042.GB10359@intel.com> <20151203181932.GA22973@obsidianresearch.com> <20151206040226.GA4396@intel.com> <20151206041544.GA5585@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1163 Lines: 31 On Mon, Dec 07, 2015 at 09:06:50AM +0100, Wilck, Martin wrote: > > > I'm a bit confused about the discussion because Martin replied that > > > tpm_tis used to get the address range before applying this series. > > > > > > And pnp_driver in the backend for TPM 1.x devices grabs the address > > > range from DSDT. > > > > You can completely ignore this question. I saw Martins reply with a fix for > > "tpm_tis: Use devm_ioremap_resource" that you should squash into that > > change. So it's proved that TPM ACPI device objects do not always have a > > memory resource. Good. > > Repeat, the memory resource DOES exist on my system. Not sure what proof > you saw there. Ok, lets go this through. I deduced this from two facts: * It used to have memory resource as conditional and as a fallback use fixed value. * Your workaround reverted the situation to this. Did I understand something incorrectly? /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/