Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755618AbbLGJMh (ORCPT ); Mon, 7 Dec 2015 04:12:37 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:60395 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755405AbbLGJMc (ORCPT ); Mon, 7 Dec 2015 04:12:32 -0500 From: Alexey Brodkin To: Vineet Gupta CC: "linux-kernel@vger.kernel.org" , "Nelson Pereira" , Joao Pinto , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH] ARC: [axs10x] enable DW DMA controller Thread-Topic: [PATCH] ARC: [axs10x] enable DW DMA controller Thread-Index: AQHRLskXgDZKdaK3MkGt1OeyEaqHO56/MHEA Date: Mon, 7 Dec 2015 09:12:27 +0000 Message-ID: <1449479546.2772.3.camel@synopsys.com> References: <1449256926-16786-1-git-send-email-abrodkin@synopsys.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.225.15.89] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB79Cgk0002513 Content-Length: 1176 Lines: 26 Hi Vineet, On Sat, 2015-12-05 at 10:14 +0000, Vineet Gupta wrote: > On Saturday 05 December 2015 12:52 AM, Alexey Brodkin wrote: > > From: Nelson Pereira > > > > ARC SDP baseboard among other peripherals sports > > DesignWare DMA controller. > > > > This enables support of that device. > > Note typically DW DMA controller is used with external devices > > connected to ARC SDP board via HAPS Extension bus. > > Such a board config needs to have it's own defconfig / DT (if needed). There's no > point in enabling this for rest of the world who don't have a use case for this IP. > > So nack ! I see rationale behind this decision but: 1) How enabled DMA controller hurts other users of the same SDP board 2) That DMA controller exists in SDP anyway - that's not a special flavor of ARC SDP 3) Another defconfig and .dts adds another item for verification while enabling DW DMA in our current defconfigs allows usage of the same one binaries for all purposes on ARC SDP. -Alexey????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?