Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754943AbbLGJ7T (ORCPT ); Mon, 7 Dec 2015 04:59:19 -0500 Received: from dgate10.ts.fujitsu.com ([80.70.172.49]:2293 "EHLO dgate10.ts.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753106AbbLGJ7R (ORCPT ); Mon, 7 Dec 2015 04:59:17 -0500 DomainKey-Signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:Received:Received:From:To:CC:Date:Subject: Thread-Topic:Thread-Index:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator:acceptlanguage: Content-Type:Content-Transfer-Encoding:MIME-Version; b=fuN2v+OigFffvomxhueywUFIn61WN08V17awTeT9wrUjOBEARbgCSNgn 9byviBUpcMXqrRiK/GwZ2IzxuVI/8c2GpBjFBzmYM0bl840BoYmbjta6n em7Upd1VWtdReQNM0LvMSaYOnvMRvx3ZtgrMCEdjH/xMHoolZ0n+fXSbf AJUDB5sA7fNoScaD5t0ZqyqVmL5AZVhn/wXCIC5QiyGvVkB7xq1Q1MR9m WhrEsww6Pk42WZ6HFdwoC1yZ0I/8z; X-SBRSScore: None From: "Wilck, Martin" To: Jason Gunthorpe CC: Jarkko Sakkinen , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Uwe Kleine-K??nig Date: Mon, 7 Dec 2015 10:59:15 +0100 Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Thread-Topic: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Thread-Index: AdEw1e46mmRGCPLHRUyS3tuhv1RwKQ== Message-ID: References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> <20151201213351.GC5071@intel.com> <20151202182726.GB30972@obsidianresearch.com> <20151202191155.GA2832@obsidianresearch.com> <20151203170041.GA32175@obsidianresearch.com> <20151204180920.GA32292@obsidianresearch.com> In-Reply-To: <20151204180920.GA32292@obsidianresearch.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: de-DE, en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB79xO9I002872 Content-Length: 965 Lines: 26 > IS_ERR should address the oops though?? No, see my answer to Jarkko in the other part of the thread. > I've put all the revised patches here: > > https://github.com/jgunthorpe/linux/commits/for-jarkko > > If you are OK with them now I'll post the series. I haven't re-reviewed it, but the test went alright. As reported before, with "force=1", I get the error message: [ 1351.677808] tpm_tis MSFT0101:00: can't request region for resource [mem 0xfed40000-0xfed44fff] [ 1351.687431] tpm_tis: probe of MSFT0101:00 failed with error -16 This is kind of misleading because the TPM is actually working as a platform device. But I can follow your previous argument that this is acceptable because people who use "force=1" should know what they are doing, so I don't regard this as critical. Martin ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?