Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932091AbbLGKJg (ORCPT ); Mon, 7 Dec 2015 05:09:36 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:33305 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754658AbbLGKJe (ORCPT ); Mon, 7 Dec 2015 05:09:34 -0500 MIME-Version: 1.0 In-Reply-To: <1449092760-21317-1-git-send-email-geyslan@gmail.com> References: <1449092760-21317-1-git-send-email-geyslan@gmail.com> Date: Mon, 7 Dec 2015 11:09:33 +0100 Message-ID: Subject: Re: [PATCH] usb: whci: fhci: remove comparison to bool From: Peter Senna Tschudin To: "Geyslan G. Bem" Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 53 On Wed, Dec 2, 2015 at 10:45 PM, Geyslan G. Bem wrote: > Get rid of bool explicit comparisons. > > Caught by Coccinelle. I would mention the path to the .cocci script, but other than that: Acked-by: Peter Senna Tschudin > > Signed-off-by: Geyslan G. Bem > --- > drivers/usb/host/fhci-tds.c | 2 +- > drivers/usb/host/whci/qset.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c > index 1498061..f82ad5d 100644 > --- a/drivers/usb/host/fhci-tds.c > +++ b/drivers/usb/host/fhci-tds.c > @@ -85,7 +85,7 @@ static struct usb_td __iomem *next_bd(struct usb_td __iomem *base, > > void fhci_push_dummy_bd(struct endpoint *ep) > { > - if (ep->already_pushed_dummy_bd == false) { > + if (!ep->already_pushed_dummy_bd) { > u16 td_status = in_be16(&ep->empty_td->status); > > out_be32(&ep->empty_td->buf_ptr, DUMMY_BD_BUFFER); > diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c > index 3297473..5e48a60 100644 > --- a/drivers/usb/host/whci/qset.c > +++ b/drivers/usb/host/whci/qset.c > @@ -395,7 +395,7 @@ static void urb_dequeue_work(struct work_struct *work) > struct whc *whc = qset->whc; > unsigned long flags; > > - if (wurb->is_async == true) > + if (wurb->is_async) > asl_update(whc, WUSBCMD_ASYNC_UPDATED > | WUSBCMD_ASYNC_SYNCED_DB > | WUSBCMD_ASYNC_QSET_RM); > -- > 2.6.3 > -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/