Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932160AbbLGKLb (ORCPT ); Mon, 7 Dec 2015 05:11:31 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:33466 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbbLGKL0 (ORCPT ); Mon, 7 Dec 2015 05:11:26 -0500 MIME-Version: 1.0 In-Reply-To: <1449098729-3347-1-git-send-email-geyslan@gmail.com> References: <1449098729-3347-1-git-send-email-geyslan@gmail.com> Date: Mon, 7 Dec 2015 11:11:25 +0100 Message-ID: Subject: Re: [PATCH] usb: ehci: ohci: fix bool assignments From: Peter Senna Tschudin To: "Geyslan G. Bem" Cc: Alan Stern , Greg Kroah-Hartman , Sergei Shtylyov , Mel Gorman , Saurabh Karajgaonkar , Masanari Iida , "Rafael J. Wysocki" , linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2812 Lines: 75 On Thu, Dec 3, 2015 at 12:25 AM, Geyslan G. Bem wrote: > When assigning bool use true instead of 1. If declaring it as static and > it's false there's no need to initialize it, since static variables are > zeroed by default. > > Caught by coccinelle. > > Signed-off-by: Geyslan G. Bem Acked-by: Peter Senna Tschudin > --- > drivers/usb/host/ehci-hcd.c | 2 +- > drivers/usb/host/ohci-hcd.c | 4 ++-- > drivers/usb/host/u132-hcd.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 48c92bf..1b01967 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO); > MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets"); > > /* for flakey hardware, ignore overcurrent indicators */ > -static bool ignore_oc = 0; > +static bool ignore_oc; > module_param (ignore_oc, bool, S_IRUGO); > MODULE_PARM_DESC (ignore_oc, "ignore bogus hardware overcurrent indications"); > > diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c > index 760cb57..5547dbf 100644 > --- a/drivers/usb/host/ohci-hcd.c > +++ b/drivers/usb/host/ohci-hcd.c > @@ -99,13 +99,13 @@ static void io_watchdog_func(unsigned long _ohci); > > > /* Some boards misreport power switching/overcurrent */ > -static bool distrust_firmware = 1; > +static bool distrust_firmware = true; > module_param (distrust_firmware, bool, 0); > MODULE_PARM_DESC (distrust_firmware, > "true to distrust firmware power/overcurrent setup"); > > /* Some boards leave IR set wrongly, since they fail BIOS/SMM handshakes */ > -static bool no_handshake = 0; > +static bool no_handshake; > module_param (no_handshake, bool, 0); > MODULE_PARM_DESC (no_handshake, "true (not default) disables BIOS handshake"); > > diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c > index 692ccc6..05c85c7 100644 > --- a/drivers/usb/host/u132-hcd.c > +++ b/drivers/usb/host/u132-hcd.c > @@ -73,7 +73,7 @@ MODULE_LICENSE("GPL"); > #define INT_MODULE_PARM(n, v) static int n = v;module_param(n, int, 0444) > INT_MODULE_PARM(testing, 0); > /* Some boards misreport power switching/overcurrent*/ > -static bool distrust_firmware = 1; > +static bool distrust_firmware = true; > module_param(distrust_firmware, bool, 0); > MODULE_PARM_DESC(distrust_firmware, "true to distrust firmware power/overcurren" > "t setup"); > -- > 2.6.3 > -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/