Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755818AbbLGK0V (ORCPT ); Mon, 7 Dec 2015 05:26:21 -0500 Received: from mail-vk0-f44.google.com ([209.85.213.44]:33775 "EHLO mail-vk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753596AbbLGK0S (ORCPT ); Mon, 7 Dec 2015 05:26:18 -0500 MIME-Version: 1.0 In-Reply-To: <566551CE.10604@linux.intel.com> References: <1449409680-19810-1-git-send-email-geyslan@gmail.com> <566551CE.10604@linux.intel.com> Date: Mon, 7 Dec 2015 07:26:17 -0300 Message-ID: Subject: Re: [PATCH] usb: host: iounmap before return From: "Geyslan G. Bem" To: Lu Baolu Cc: Peter Senna Tschudin , Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1726 Lines: 57 2015-12-07 6:30 GMT-03:00 Lu Baolu : > > > On 12/06/2015 09:47 PM, Geyslan G. Bem wrote: >> This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not unmapping correctly. >> >> Coccinelle: scripts/coccinelle/free/iounmap.cocci >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/pci-quirks.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c >> index f940056..64150dd 100644 >> --- a/drivers/usb/host/pci-quirks.c >> +++ b/drivers/usb/host/pci-quirks.c >> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) >> /* We're reading garbage from the controller */ >> dev_warn(&pdev->dev, >> "xHCI controller failing to respond"); >> - return; >> + goto out; > > If "out" is only used here, why not iounmap and return directly here? Could be directly. I just think that code recurrence can make things complicated in future. What do you think? Ah, seems that this patch is not aligned with linux-next. I'll make a new one soon. > >> } >> >> if (!ext_cap_offset) >> @@ -1062,6 +1062,7 @@ hc_init: >> XHCI_MAX_HALT_USEC, val); >> } >> >> +out: >> iounmap(base); >> } >> > -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/