From: Arnd Bergmann <arnd@arndb.de>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Daniel Cashman <dcashman@android.com>, linux-kernel@vger.kernel.org,
        dcashman@google.com, linux-doc@vger.kernel.org,
        catalin.marinas@arm.com, will.deacon@arm.com, linux-mm@kvack.org,
        hpa@zytor.com, mingo@kernel.org, aarcange@redhat.com,
        linux@arm.linux.org.uk, corbet@lwn.net, xypron.glpk@gmx.de,
        x86@kernel.org, hecmargi@upv.es, mgorman@suse.de, rientjes@google.com,
        bp@suse.de, nnk@google.com, dzickus@redhat.com, keescook@chromium.org,
        jpoimboe@redhat.com, tglx@linutronix.de, n-horiguchi@ah.jp.nec.com,
        linux-arm-kernel@lists.infradead.org, salyzyn@android.com,
        ebiederm@xmission.com, jeffv@google.com, akpm@linux-foundation.org,
        kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.
Date: Mon, 07 Dec 2015 12:13:55 +0100
Message-ID: <1720878.JdEcLd8bhL@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <56655EC8.6030905@nvidia.com>
References: <1449000658-11475-1-git-send-email-dcashman@android.com> <1449000658-11475-4-git-send-email-dcashman@android.com> <56655EC8.6030905@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 935
Lines: 30

On Monday 07 December 2015 10:26:16 Jon Hunter wrote:
> 
> diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
> index af461b935137..e59a75a308bc 100644
> --- a/arch/arm64/mm/mmap.c
> +++ b/arch/arm64/mm/mmap.c
> @@ -51,7 +51,7 @@ unsigned long arch_mmap_rnd(void)
>  {
>         unsigned long rnd;
>  
> -ifdef CONFIG_COMPAT
> +#ifdef CONFIG_COMPAT
>         if (test_thread_flag(TIF_32BIT))
>                 rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_compat_bits);
>         else
> 
> Cheers
> 

Ideally we'd remove the #ifdef around the mmap_rnd_compat_bits declaration
and change this code to use

	if (IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT))

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/