Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755973AbbLGLQe (ORCPT ); Mon, 7 Dec 2015 06:16:34 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:60762 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755913AbbLGLQc (ORCPT ); Mon, 7 Dec 2015 06:16:32 -0500 From: Arnd Bergmann To: Jon Hunter Cc: Daniel Cashman , linux-kernel@vger.kernel.org, dcashman@google.com, linux-doc@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-mm@kvack.org, hpa@zytor.com, mingo@kernel.org, aarcange@redhat.com, linux@arm.linux.org.uk, corbet@lwn.net, xypron.glpk@gmx.de, x86@kernel.org, hecmargi@upv.es, mgorman@suse.de, rientjes@google.com, bp@suse.de, nnk@google.com, dzickus@redhat.com, keescook@chromium.org, jpoimboe@redhat.com, tglx@linutronix.de, n-horiguchi@ah.jp.nec.com, linux-arm-kernel@lists.infradead.org, salyzyn@android.com, ebiederm@xmission.com, jeffv@google.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com Subject: Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS. Date: Mon, 07 Dec 2015 12:13:55 +0100 Message-ID: <1720878.JdEcLd8bhL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56655EC8.6030905@nvidia.com> References: <1449000658-11475-1-git-send-email-dcashman@android.com> <1449000658-11475-4-git-send-email-dcashman@android.com> <56655EC8.6030905@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MSRoUOfDUs4zmjhp60M1WE6CbW7EoaqVm8m6iYH+Cfw+fDR4p8W jW5cyQ3LN7R2D+HFq4C0rF3kzknbvV2WQKsMPLJZJqxsZtpwBTHRSCBfAEpuGgvd6mp6jQB t4R/fZncKyyF9Xf3vrQ1owXtI2Cf9+phMlLWPqkMo7QaSur9/x9hE/Hj/whpIj8mKPP6ONG ZEzfQ/05wMWWbdCO9wjDw== X-UI-Out-Filterresults: notjunk:1;V01:K0:AVdTKw/6uDY=:3LM7rwg5zAnpnc3GMgTkTf thxhPgW0Qzp+wXPdHDW2qOF3RciN2y6H2zIDBGITFKvOg6ET0zTIStQhA/1G48TgFzrt0Z+nz S3HDs9laiZ1LdfycaEzsP2cMNvtQ6d6qCJY++vJ9gh7kCxo0uEFExJGSeRPiGObOKYmd6IQql 3Ds2dz1osfnsFifvgwr/6uANGdPErNgb+kiyZB2fgS7JEeuTZAUbtLXiYLO8KZMt9ogkJmVBz ocMWDh6nBXQl+KDfFlQZvWqFY6m4CX4/xAbqWb1kghy/OJdgpYSh8K7Xx7QVJLiKcUhNccF2F hmt9RIw1Xf1yNPD+9fPOU9J4imAQDjkEBPIGJyP1dZPqVFNUenDT4nZDVBxACH6gVm+ipp4/q h/vBvnHZVjhziOmwflUUKXGmygXG2FJa1MRV2GZFsrjsmmIg+H8zvTTFCUT/1L2wp0K2aW0wi I87n5MrDcnz0BJHFAvP5sKSV0EIfSdynEzhEYza9Bvbm8wca8nLO5m6E69G5wtYE5lkML76TM ktHA2pqECa12LC9SNYwS1KlTOkjkfXgb2EzA4PVXW6caWUAdfZPBushl6YTPx0WR/kWin3dMu yS2GvFagO1xmBvpK5pznx7+bd+NddA6TrT8OMUVm2qp/TQQSwOqOMj9WbS+m4rnKU3d3qAalH 8tmvRkMUG0QnxoOBZLoL32QTKJWw8q/xoDAUzq8OzlClSgqQXQQgw43d7zHGSRXc2Bdvl6VKj zDDxE8a1QOnDl02G Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 30 On Monday 07 December 2015 10:26:16 Jon Hunter wrote: > > diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c > index af461b935137..e59a75a308bc 100644 > --- a/arch/arm64/mm/mmap.c > +++ b/arch/arm64/mm/mmap.c > @@ -51,7 +51,7 @@ unsigned long arch_mmap_rnd(void) > { > unsigned long rnd; > > -ifdef CONFIG_COMPAT > +#ifdef CONFIG_COMPAT > if (test_thread_flag(TIF_32BIT)) > rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_compat_bits); > else > > Cheers > Ideally we'd remove the #ifdef around the mmap_rnd_compat_bits declaration and change this code to use if (IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT)) Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/