Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755713AbbLGLha (ORCPT ); Mon, 7 Dec 2015 06:37:30 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:34875 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753643AbbLGLh2 (ORCPT ); Mon, 7 Dec 2015 06:37:28 -0500 Subject: Re: [PATCH] usb: host: iounmap before return To: Lu Baolu , "Geyslan G. Bem" , peter.senna@gmail.com References: <1449409680-19810-1-git-send-email-geyslan@gmail.com> <566551CE.10604@linux.intel.com> Cc: Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56656F74.1020909@cogentembedded.com> Date: Mon, 7 Dec 2015 14:37:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <566551CE.10604@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 47 Hello. On 12/07/2015 12:30 PM, Lu Baolu wrote: >> This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not unmapping correctly. >> >> Coccinelle: scripts/coccinelle/free/iounmap.cocci >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/pci-quirks.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c >> index f940056..64150dd 100644 >> --- a/drivers/usb/host/pci-quirks.c >> +++ b/drivers/usb/host/pci-quirks.c >> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) >> /* We're reading garbage from the controller */ >> dev_warn(&pdev->dev, >> "xHCI controller failing to respond"); >> - return; >> + goto out; > > If "out" is only used here, why not iounmap and return directly here? Why repeat the code? Nah, bad idea. >> } >> >> if (!ext_cap_offset) >> @@ -1062,6 +1062,7 @@ hc_init: >> XHCI_MAX_HALT_USEC, val); >> } >> >> +out: >> iounmap(base); >> } >> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/