Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933778AbbLGPQN (ORCPT ); Mon, 7 Dec 2015 10:16:13 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:10861 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755189AbbLGPQK (ORCPT ); Mon, 7 Dec 2015 10:16:10 -0500 Date: Mon, 7 Dec 2015 16:15:56 +0100 From: Ludovic Desroches To: Cyrille Pitchen CC: , , , , , , Subject: Re: [PATCH 1/1] dmaengine: at_xdmac: fix at_xdmac_prep_dma_memcpy() Message-ID: <20151207151556.GD27886@odux.rfo.atmel.com> Mail-Followup-To: Cyrille Pitchen , nicolas.ferre@atmel.com, dan.j.williams@intel.com, vinod.koul@intel.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 39 On Mon, Dec 07, 2015 at 03:58:56PM +0100, Cyrille Pitchen wrote: > This patch fixes at_xdmac_prep_dma_memcpy(). Indeed the data width field > of the Channel Configuration register was not updated properly in the > loop: the bits of the dwidth field were not cleared before adding their > new value. > > Signed-off-by: Cyrille Pitchen Thanks. Acked-by: Ludovic Desroches Fixes: e1f7c9eee70 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Cc: stable@vger.kernel.org #4.1 and later (minor conflict due to the introduction of at_xdmac_align_width() in 4.2 to factorize code) > --- > drivers/dma/at_xdmac.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index 90040e99f5f3..39f59666f93f 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -1096,6 +1096,7 @@ at_xdmac_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src, > /* Check remaining length and change data width if needed. */ > dwidth = at_xdmac_align_width(chan, > src_addr | dst_addr | xfer_size); > + chan_cc &= ~AT_XDMAC_CC_DWIDTH_MASK; > chan_cc |= AT_XDMAC_CC_DWIDTH(dwidth); > > ublen = xfer_size >> dwidth; > -- > 1.8.2.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/