Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756185AbbLGPvg (ORCPT ); Mon, 7 Dec 2015 10:51:36 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:19568 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755379AbbLGPve (ORCPT ); Mon, 7 Dec 2015 10:51:34 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 07 Dec 2015 07:48:22 -0800 Subject: Re: [PATCH 2/3] clk: tegra210: Fix sparse warnings for functions not declared as static To: Jon Hunter , Peter De Schrijver , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Stephen Warren , Thierry Reding , Alexandre Courbot References: <1449248665-22343-1-git-send-email-jonathanh@nvidia.com> <1449248665-22343-2-git-send-email-jonathanh@nvidia.com> CC: , , From: Rhyland Klein Message-ID: <5665AB03.3000304@nvidia.com> Date: Mon, 7 Dec 2015 10:51:31 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449248665-22343-2-git-send-email-jonathanh@nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2818 Lines: 56 On 12/4/2015 12:04 PM, Jon Hunter wrote: > Sparse reports the following warnings for functions in clk-tegra210.c > that should be declared as static: > > drivers/clk/tegra/clk-tegra210.c:460:6: warning: symbol > 'tegra210_pllcx_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:485:6: warning: symbol > '_pllc_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:490:6: warning: symbol > '_pllc2_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:495:6: warning: symbol > '_pllc3_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:500:6: warning: symbol > '_plla1_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:510:6: warning: symbol > 'tegra210_plla_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:562:6: warning: symbol > 'tegra210_plld_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:701:6: warning: symbol > 'tegra210_plld2_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:709:6: warning: symbol > 'tegra210_plldp_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:722:6: warning: symbol > 'tegra210_pllc4_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:731:6: warning: symbol > 'tegra210_pllre_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:844:6: warning: symbol > 'tegra210_pllx_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:904:6: warning: symbol > 'tegra210_pllmb_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:963:6: warning: symbol > 'tegra210_pllp_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:1025:6: warning: symbol > 'tegra210_pllu_set_defaults' was not declared. Should it be static? > drivers/clk/tegra/clk-tegra210.c:1215:15: warning: symbol > 'tegra210_clk_adjust_vco_min' was not declared. Should it be static? > > Fix this by declaring the above as static. > > Fixes: b31eba5ff3f7 ("clk: tegra: Add support for Tegra210 clocks") > > Signed-off-by: Jon Hunter > --- > drivers/clk/tegra/clk-tegra210.c | 36 +++++++++++++++++++----------------- > 1 file changed, 19 insertions(+), 17 deletions(-) ... Acked-by: Rhyland Klein -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/