Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756190AbbLGQzI (ORCPT ); Mon, 7 Dec 2015 11:55:08 -0500 Received: from mail-yk0-f175.google.com ([209.85.160.175]:34575 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755592AbbLGQzH (ORCPT ); Mon, 7 Dec 2015 11:55:07 -0500 MIME-Version: 1.0 In-Reply-To: <87a8pmzly4.fsf@intel.com> References: <201511302050.evPZc1zs%fengguang.wu@intel.com> <56651937.1080405@codeaurora.org> <87a8pmzly4.fsf@intel.com> Date: Mon, 7 Dec 2015 11:55:06 -0500 Message-ID: Subject: Re: [PATCH v3 2/5] drm/dsi: Try to match non-DT dsi devices From: Rob Clark To: Jani Nikula Cc: Archit Taneja , "dri-devel@lists.freedesktop.org" , Daniel Vetter , linux-arm-msm , Linux Kernel Mailing List , Andrzej Hajda , Thierry Reding Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1698 Lines: 47 On Mon, Dec 7, 2015 at 3:45 AM, Jani Nikula wrote: > On Mon, 07 Dec 2015, Archit Taneja wrote: >> Hi, >> >> On 11/30/2015 06:15 PM, kbuild test robot wrote: >>> Hi Archit, >>> >>> [auto build test ERROR on: v4.4-rc3] >>> [also build test ERROR on: next-20151127] >>> >>> url: https://github.com/0day-ci/linux/commits/Archit-Taneja/drm-dsi-DSI-for-devices-with-different-control-bus/20151130-200725 >>> config: x86_64-allyesdebian (attached as .config) >>> reproduce: >>> # save the attached .config to linux build tree >>> make ARCH=x86_64 >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/gpu/drm/drm_mipi_dsi.c: In function 'of_mipi_dsi_device_add': >>>>> drivers/gpu/drm/drm_mipi_dsi.c:168:6: error: implicit declaration of function 'of_modalias_node' [-Werror=implicit-function-declaration] >>> if (of_modalias_node(node, info.type, sizeof(info.type)) < 0) { >> >> Any suggestions on how to fix this? Is it ok to make DRM_MIPI_DSI >> depend on CONFIG_OF? > > Please don't. I assume you are not using of_mipi_dsi_device_add()? We could just put this one fxn inside #ifdef CONFIG_OF / #endif, I think.. BR, -R > BR, > Jani. > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/