Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756212AbbLGQz6 (ORCPT ); Mon, 7 Dec 2015 11:55:58 -0500 Received: from mail-yk0-f179.google.com ([209.85.160.179]:34822 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbbLGQz5 (ORCPT ); Mon, 7 Dec 2015 11:55:57 -0500 MIME-Version: 1.0 In-Reply-To: <1449431361-6844-1-git-send-email-saurabh.truth@gmail.com> References: <1449431361-6844-1-git-send-email-saurabh.truth@gmail.com> Date: Mon, 7 Dec 2015 11:55:56 -0500 Message-ID: Subject: Re: [PATCH] drm: msm: dsi: Added missing mutex_unlock From: Rob Clark To: Saurabh Sengar Cc: David Airlie , Hai Li , Archit Taneja , Stephane Viau , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 37 On Sun, Dec 6, 2015 at 2:49 PM, Saurabh Sengar wrote: > in case of failed to get iova, function was returning without releasing > the mutex. Added it. > > Signed-off-by: Saurabh Sengar Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 4c49868..13f937b 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -849,11 +849,11 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size) > } > > ret = msm_gem_get_iova_locked(msm_host->tx_gem_obj, 0, &iova); > + mutex_unlock(&dev->struct_mutex); > if (ret) { > pr_err("%s: failed to get iova, %d\n", __func__, ret); > return ret; > } > - mutex_unlock(&dev->struct_mutex); > > if (iova & 0x07) { > pr_err("%s: buf NOT 8 bytes aligned\n", __func__); > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/