Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932355AbbLGRfj (ORCPT ); Mon, 7 Dec 2015 12:35:39 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:41435 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932194AbbLGRfh (ORCPT ); Mon, 7 Dec 2015 12:35:37 -0500 Date: Mon, 7 Dec 2015 10:35:31 -0700 From: Jason Gunthorpe To: "Wilck, Martin" Cc: Jarkko Sakkinen , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Uwe Kleine-K??nig Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Message-ID: <20151207173531.GA13989@obsidianresearch.com> References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> <20151201213351.GC5071@intel.com> <20151202182726.GB30972@obsidianresearch.com> <20151202191155.GA2832@obsidianresearch.com> <20151203170041.GA32175@obsidianresearch.com> <20151204180920.GA32292@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 28 On Mon, Dec 07, 2015 at 10:59:15AM +0100, Wilck, Martin wrote: > > IS_ERR should address the oops though?? > > No, see my answer to Jarkko in the other part of the thread. I'm confused, is there an oops that still need to be fixed? > As reported before, with "force=1", I get the error message: > > [ 1351.677808] tpm_tis MSFT0101:00: can't request region for resource > [mem 0xfed40000-0xfed44fff] > [ 1351.687431] tpm_tis: probe of MSFT0101:00 failed with error -16 Great, that you so much, that is what I expected to see! > This is kind of misleading because the TPM is actually working as a > platform device. But I can follow your previous argument that this is > acceptable because people who use "force=1" should know what they are > doing, so I don't regard this as critical. Right. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/