Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755997AbbLGRvW (ORCPT ); Mon, 7 Dec 2015 12:51:22 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:9320 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752383AbbLGRvU (ORCPT ); Mon, 7 Dec 2015 12:51:20 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 07 Dec 2015 09:37:40 -0800 Subject: Re: [PATCH 3/3] clk: tegra-super: Fix sparse warnings for functions not declared as static To: Jon Hunter , Peter De Schrijver , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Stephen Warren , Thierry Reding , Alexandre Courbot References: <1449248665-22343-1-git-send-email-jonathanh@nvidia.com> <1449248665-22343-3-git-send-email-jonathanh@nvidia.com> <5665AB15.80602@nvidia.com> CC: , , From: Rhyland Klein Message-ID: <5665C715.7030608@nvidia.com> Date: Mon, 7 Dec 2015 12:51:17 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5665AB15.80602@nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1415 Lines: 38 On 12/7/2015 10:51 AM, Rhyland Klein wrote: > On 12/4/2015 12:04 PM, Jon Hunter wrote: >> Sparse reports the following warnings for structures and functions that >> should be declared static: >> >> drivers/clk/tegra/clk-tegra-super-gen4.c:70:35: warning: symbol >> 'tegra_super_gen_info_gen4' was not declared. Should it be static? >> drivers/clk/tegra/clk-tegra-super-gen4.c:96:35: warning: symbol >> 'tegra_super_gen_info_gen5' was not declared. Should it be static? >> drivers/clk/tegra/clk-tegra-super-gen4.c:174:13: warning: symbol >> 'tegra_super_clk_init' was not declared. Should it be static? >> >> Fix this by making the above static. >> >> Fixes: 88467d220119 ("clk: tegra: Add Super Gen5 Logic") >> >> Signed-off-by: Jon Hunter >> --- >> drivers/clk/tegra/clk-tegra-super-gen4.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > ... > > Acked-by: Rhyland Klein > Actually, Don't you need to change the function declarations in drivers/clk/tegra/clk.h for tegra_super_clk_gen[4|5]_init otherwise you will get mismatches with one being declared static and the other not? -rhyland -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/