Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932548AbbLGSHX (ORCPT ); Mon, 7 Dec 2015 13:07:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932177AbbLGSHV (ORCPT ); Mon, 7 Dec 2015 13:07:21 -0500 Subject: Re: [PATCH v2 0/2] dm verity: add support for error correction To: Sami Tolvanen , Mike Snitzer References: <1446688954-29589-1-git-send-email-samitolvanen@google.com> <1449152791-33586-1-git-send-email-samitolvanen@google.com> <20151203195401.GA5444@redhat.com> <20151203230538.GB5444@redhat.com> <20151204100305.GA37949@google.com> <20151204210935.GA63877@redhat.com> <20151207132149.GA7583@google.com> <20151207145814.GB29457@redhat.com> <20151207163108.GA21472@google.com> Cc: Mikulas Patocka , Mandeep Baines , Will Drewry , Alasdair Kergon , dm-devel@redhat.com, linux-kernel@vger.kernel.org, Kees Cook , Mark Salyzyn From: Milan Broz Message-ID: <5665CAD5.9000704@redhat.com> Date: Mon, 7 Dec 2015 19:07:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 In-Reply-To: <20151207163108.GA21472@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 23 On 12/07/2015 05:31 PM, Sami Tolvanen wrote: > On Mon, Dec 07, 2015 at 09:58:14AM -0500, Mike Snitzer wrote: >> Great. Moving forward it'd be awesome if you could work to get your >> verity FEC support regression tests into cryptsetup's tests. > > Sure. These tests would basically involve generating a valid disk > image, corrupting it up to the theoretical maximum, and verifying that > dm-verity can correct it. Does the code handle/report even the same type of data corruption for RS blocks? Or this is just silently ignored until data area corruption happens? Sorry, I did not study the code here, I am just curious :) (IOW I mean if data are ok but recovery metadata is corrupted.) Milan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/