Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932556AbbLGSNO (ORCPT ); Mon, 7 Dec 2015 13:13:14 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:35073 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932470AbbLGSNM (ORCPT ); Mon, 7 Dec 2015 13:13:12 -0500 Date: Mon, 7 Dec 2015 10:13:08 -0800 From: Brian Norris To: Rob Herring Cc: "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Boris Brezillon , Linus Walleij , Geert Uytterhoeven , Simon Arlott , Jason Gunthorpe , Jonas Gorski , "devicetree@vger.kernel.org" , "devicetree-spec@vger.kernel.org" , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Hauke Mehrtens , Arnd Bergmann Subject: Re: [RFC PATCH 4/7] mtd: add of_match_mtd_parser() and of_mtd_match_mtd_parser() helpers Message-ID: <20151207181308.GN120110@google.com> References: <1449292763-129421-1-git-send-email-computersforpeace@gmail.com> <1449292763-129421-5-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 20 On Sun, Dec 06, 2015 at 08:45:40PM -0600, Rob Herring wrote: > On Fri, Dec 4, 2015 at 11:19 PM, Brian Norris > wrote: > > drivers/of/of_mtd.c | 33 +++++++++++++++++++++++++++++++++ > > BTW, this file should be moved to drivers/mtd/ at some point. How about s/at some point/now/ ? I can send a separate patch. It also seems like these should just get linked into the 'mtd' module (when CONFIG_OF=y) instead of having a tiny module for just a few functions. Why did files like this get placed here anyway? Is there a reason that there are things like of_net and of_pci here too? Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/