Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932711AbbLGTAz (ORCPT ); Mon, 7 Dec 2015 14:00:55 -0500 Received: from mail.kernel.org ([198.145.29.136]:37492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755154AbbLGTAx (ORCPT ); Mon, 7 Dec 2015 14:00:53 -0500 MIME-Version: 1.0 In-Reply-To: <20151207181308.GN120110@google.com> References: <1449292763-129421-1-git-send-email-computersforpeace@gmail.com> <1449292763-129421-5-git-send-email-computersforpeace@gmail.com> <20151207181308.GN120110@google.com> From: Rob Herring Date: Mon, 7 Dec 2015 13:00:30 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 4/7] mtd: add of_match_mtd_parser() and of_mtd_match_mtd_parser() helpers To: Brian Norris Cc: "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Boris Brezillon , Linus Walleij , Geert Uytterhoeven , Simon Arlott , Jason Gunthorpe , Jonas Gorski , "devicetree@vger.kernel.org" , "devicetree-spec@vger.kernel.org" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Hauke Mehrtens , Arnd Bergmann Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1362 Lines: 36 On Mon, Dec 7, 2015 at 12:13 PM, Brian Norris wrote: > On Sun, Dec 06, 2015 at 08:45:40PM -0600, Rob Herring wrote: >> On Fri, Dec 4, 2015 at 11:19 PM, Brian Norris >> wrote: >> > drivers/of/of_mtd.c | 33 +++++++++++++++++++++++++++++++++ >> >> BTW, this file should be moved to drivers/mtd/ at some point. > > How about s/at some point/now/ ? Great. > I can send a separate patch. It also > seems like these should just get linked into the 'mtd' module (when > CONFIG_OF=y) instead of having a tiny module for just a few functions. Agreed. > Why did files like this get placed here anyway? Is there a reason that > there are things like of_net and of_pci here too? Things started out here, but as the number of subsystems and associated bindings grew it became evident that binding specific things should go with the subsystems. I also have a secret goal to eliminate drivers/of. Don't tell anyone. of_net should probably move, just no one has had the itch to do it. PCI is a bit special and somewhat tied into the rest of the core. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/