Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932713AbbLGTc2 (ORCPT ); Mon, 7 Dec 2015 14:32:28 -0500 Received: from skprod2.natinst.com ([130.164.80.23]:39690 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755143AbbLGTc1 (ORCPT ); Mon, 7 Dec 2015 14:32:27 -0500 Date: Mon, 7 Dec 2015 13:32:15 -0600 From: Josh Cartwright To: Neil Armstrong Cc: Nicolas Ferre , "David S. Miller" , Harini Katakam , Boris BREZILLON , Alexandre Belloni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms Message-ID: <20151207193215.GI29051@jcartwri.amer.corp.natinst.com> References: <1449485914-12883-1-git-send-email-narmstrong@baylibre.com> <1449485914-12883-2-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 In-Reply-To: <1449485914-12883-2-git-send-email-narmstrong@baylibre.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 12/07/2015 01:32:15 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 12/07/2015 01:32:17 PM, Serialize complete at 12/07/2015 01:32:17 PM Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="smOfPzt+Qjm5bNGJ" Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-12-07_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 45 --smOfPzt+Qjm5bNGJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 07, 2015 at 11:58:33AM +0100, Neil Armstrong wrote: > On some platforms, the macb integration does not use the USRIO > register to configure the (R)MII port and clocks. > When the register is not implemented and the MACB error signal > is connected to the bus error, reading or writing to the USRIO > register can trigger some Imprecise External Aborts on ARM platforms. > --- Does this make sense to even be a separate bool device tree property? This sort of configuration is typically done by: 1. Creating a new 'caps' bit; relevant codepaths check that bit 2. Creating a new "compatible" string for your platform's macb instance 3. Creating a new 'struct macb_config' instance for your platform, setting any relevant caps bits when it is selected. Josh --smOfPzt+Qjm5bNGJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJWZd68AAoJEKp7ZBKwQFAr1W4H/jZAVm4x25e3YDa0YoxFhdug Z8AwjPSJUG4h7ScuMHdSffrcxcIX+nBvN7ilDGXVuxUePwZYS6zVYBvLLH+rtVRC IyixXM+xgX+bxCvDuM40Yl0CbXY9Y44sqxPFhHdthEyDfSMElyLjuc3Btj+1FAce QlhOznwSs4c+1wXaaLlolQgpEH9g4zly9ghmRenCFi5tPWO8p+h514pQLO3/wrq2 rZBsyhYYgCvExhMEmd0iDfsG3t8aVEZgfJBSAaR6KdaujXYUsR4q8UKSpfgSNMOP cjajvQrrIMx4Dp/StIIjFTRl6ipFfegZm7OPSAiImaq4OLBi7fcEXs+Vz4iljmU= =rV7l -----END PGP SIGNATURE----- --smOfPzt+Qjm5bNGJ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/