Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932841AbbLGTkO (ORCPT ); Mon, 7 Dec 2015 14:40:14 -0500 Received: from mail-ig0-f175.google.com ([209.85.213.175]:34525 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932469AbbLGTkC (ORCPT ); Mon, 7 Dec 2015 14:40:02 -0500 MIME-Version: 1.0 In-Reply-To: <87bna36v91.fsf@gamma.ozlabs.ibm.com> References: <1449388004.2096.12.camel@hbabu-laptop> <87bna36v91.fsf@gamma.ozlabs.ibm.com> From: Dan Streetman Date: Mon, 7 Dec 2015 14:39:22 -0500 X-Google-Sender-Auth: kSP7_dVQVPCjrIl1TeeylK-aohs Message-ID: Subject: Re: crypto/nx842: Ignore queue overflow informative error To: Daniel Axtens Cc: Haren Myneni , Herbert Xu , "David S. Miller" , Michael Ellerman , pair@us.ibm.com, Linux Crypto Mailing List , linux-kernel , "linuxppc-dev@lists.ozlabs.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2313 Lines: 60 On Sun, Dec 6, 2015 at 5:57 PM, Daniel Axtens wrote: > Haren Myneni writes: > >> NX842 coprocessor sets bit 3 if queue is overflow. It is just for >> information to the user. So the driver prints this informative message >> and ignores it. > > What queue, and what happens when the queue overflows? It seems like > *something* would need to be done, somewhere, by someone? > > I realise that as a piece of IBM hardware this is probably an incredibly > optimistic question, but is this behaviour documented publically anywhere? > (As a distant second best, is it documented internally anywhere that I > can read?) When I worked there, it unfortunately wasn't public and there was no future plan to make it public, but things might have changed since I left. Maybe it will be included in future openpower documentation...? > >> --- a/drivers/crypto/nx/nx-842-powernv.c >> +++ b/drivers/crypto/nx/nx-842-powernv.c >> @@ -442,6 +442,15 @@ static int nx842_powernv_function(const unsigned char *in, unsigned int inlen, >> (unsigned int)ccw, >> (unsigned int)be32_to_cpu(crb->ccw)); >> >> + /* >> + * NX842 coprocessor uses 3rd bit to report queue overflow which is >> + * not an error, just for information to user. So, ignore this bit. >> + */ >> + if (ret & ICSWX_BIT3) { >> + pr_info_ratelimited("842 coprocessor queue overflow\n"); > It doesn't look like this is done anywhere else in the file, but should > this be prefixed with something? Something like "nx-842: Coprocessor > queue overflow"? it defines pr_fmt at the top of the file so it will be prefixed with the module name. > > Regards, > Daniel > >> + ret &= ~ICSWX_BIT3; >> + } >> + >> switch (ret) { >> case ICSWX_INITIATED: >> ret = wait_for_csb(wmem, csb); >> >> >> _______________________________________________ >> Linuxppc-dev mailing list >> Linuxppc-dev@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/linuxppc-dev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/