Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755598AbbLGVY3 (ORCPT ); Mon, 7 Dec 2015 16:24:29 -0500 Received: from thejh.net ([37.221.195.125]:56321 "EHLO thejh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbbLGVYZ (ORCPT ); Mon, 7 Dec 2015 16:24:25 -0500 From: Jann Horn To: Andrew Morton , Kees Cook , Casey Schaufler Cc: Oleg Nesterov , Ingo Molnar , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Andy Lutomirski , Al Viro , "Eric W. Biederman" , Joe Perches , Thomas Gleixner , Michael Kerrisk , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, security@kernel.org, Willy Tarreau Subject: Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks Date: Mon, 7 Dec 2015 22:25:10 +0100 Message-Id: <1449523512-29200-1-git-send-email-jann@thejh.net> X-Mailer: git-send-email 2.1.4 In-Reply-To: <20151207203824.GA27364@pc.thejh.net> References: <20151207203824.GA27364@pc.thejh.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 12 Whoops. After Kees pointed out my last mistake, I decided to grep around a bit to make sure I didn't miss anything else and noticed that apparently, Yama and Smack aren't completely aware that the ptrace access mode can have flags ORed in? Until now, it was just the NOAUDIT flag for /proc/$pid/stat, but with my patch, that would have been broken completely as far as I can tell. I don't use either of those LSMs and didn't test with them. Can the LSM maintainers have a look at this and say whether this looks okay now? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/