Date: Mon, 07 Dec 2015 16:28:02 -0500 (EST)
Message-Id: <20151207.162802.462148155042537146.davem@davemloft.net>
To: sowmini.varadhan@oracle.com
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, jeffrey.t.kirsher@intel.com,
        jesse.brandeburg@intel.com, shannon.nelson@intel.com,
        carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
        matthew.vick@intel.com, john.ronciak@intel.com,
        mitch.a.williams@intel.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM
From: David Miller <davem@davemloft.net>
In-Reply-To: <20151207200634.GA4415@oracle.com>
References: <20151207200634.GA4415@oracle.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1428
Lines: 33

From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Mon, 7 Dec 2015 15:06:34 -0500

> This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC
> address in Open Firmware or IDPROM").
> 
> As with that fix, attempt to look up the MAC address in Open Firmware
> on systems that support it, and use IDPROM on SPARC if no OF address
> is found.
> 
> In the case of the i40e there is an assumption that the default mac
> address has already been set up as the primary mac filter on probe,
> so if this filter is obtained from the Open Firmware or IDPROM, an
> explicit write is needed via i40e_aq_mac_address_write() and
> i40e_aq_add_macvlan() invocation.
> 
> The I40E_FLAG_PF_MAC flag in the platform-private i40e_pf structure
> tracks whether a platform-specific mac address was found, in which
> case calls to i40e_aq_mac_address_write() and i40e_aq_add_macvlan()
> will be triggered.
> 
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>

This looks good to me.

Once this goes in I'll add my generic MAC stuff to net-next and then
we can convert the various Intel drivers to use it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/