Date: Mon, 7 Dec 2015 16:33:43 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Denis Kirjanov <kda@linux-powerpc.org>,
        Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline
 CPUs
Message-ID: <20151207163343.0ea2f1bb@gandalf.local.home>
In-Reply-To: <1449522135.21036.11.camel@kernel.crashing.org>
References: <1448389419-5296-1-git-send-email-kda@linux-powerpc.org>
	<1448389419-5296-2-git-send-email-kda@linux-powerpc.org>
	<20151207155224.2a8d71dd@gandalf.local.home>
	<1449522135.21036.11.camel@kernel.crashing.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 697
Lines: 20

On Tue, 08 Dec 2015 08:02:15 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote:
> > > +     TP_CONDITION(cpu_online(smp_processor_id())),
> > > +  
> 
> This should probably be some kind of __raw version though, hcalls can
> be called in contexts where the debug stuff in smp_processor_id() isn't
> safe (or preempt enabled).
> 

OK, then that needs to be updated.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/