Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756714AbbLGWoH (ORCPT ); Mon, 7 Dec 2015 17:44:07 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:51287 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756399AbbLGWoE (ORCPT ); Mon, 7 Dec 2015 17:44:04 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Mon, 07 Dec 2015 14:42:25 -0800 From: Stefan Agner To: Boris Brezillon Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ralf Baechle , linux-mips@linux-mips.org, Josh Wu , Ezequiel Garcia , Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Kyungmin Park , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, punnaiah choudary kalluri Subject: Re: [PATCH 09/23] mtd: nand: vf610: remove useless mtd->ecclayout assignment In-Reply-To: <1449527178-5930-10-git-send-email-boris.brezillon@free-electrons.com> References: <1449527178-5930-1-git-send-email-boris.brezillon@free-electrons.com> <1449527178-5930-10-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <97ccabe846d9410df0a28a2805b94a2e@agner.ch> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 31 On 2015-12-07 14:26, Boris Brezillon wrote: > The NAND core layer is already taking care of ecclayout propagation. Remove > this useless assignment. Thx! I see, nand_scan_tail takes care of that... Acked-by: Stefan Agner > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/vf610_nfc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c > index 1c86c6b..0413e24 100644 > --- a/drivers/mtd/nand/vf610_nfc.c > +++ b/drivers/mtd/nand/vf610_nfc.c > @@ -794,8 +794,6 @@ static int vf610_nfc_probe(struct platform_device *pdev) > goto error; > } > > - /* propagate ecc.layout to mtd_info */ > - mtd->ecclayout = chip->ecc.layout; > chip->ecc.read_page = vf610_nfc_read_page; > chip->ecc.write_page = vf610_nfc_write_page; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/