Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932990AbbLGXNV (ORCPT ); Mon, 7 Dec 2015 18:13:21 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:34961 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756009AbbLGXNT (ORCPT ); Mon, 7 Dec 2015 18:13:19 -0500 MIME-Version: 1.0 From: Andy Lutomirski Date: Mon, 7 Dec 2015 15:12:59 -0800 Message-ID: Subject: [PSEUDOPATCH] rename is_compat_task To: Linus Torvalds , X86 ML , "linux-kernel@vger.kernel.org" , linux-arch Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 947 Lines: 25 Hi all- Every time I look at is_compat_task, I cringe. That function determines whether we're in a compat syscall, not whether we're in a compat task. There are probably architectures (arm64?) under which these are the same conditions, but they are definitely *not* the same thing on x86. Can we just fix it? I propose the following patch: $ find -type f |xargs sed -i -e 's/is_compat_task/in_compat_syscall/g' If there's general agreement, can we do that at the end of the next merge window? I could also send a patch series to add in_compat_syscall, change all the users, then delete the old stuff, but that seems overcomplicated for something that's literally just renaming a token. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/