Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964930AbbLGXg3 (ORCPT ); Mon, 7 Dec 2015 18:36:29 -0500 Received: from mail-vk0-f49.google.com ([209.85.213.49]:36691 "EHLO mail-vk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964799AbbLGXg1 (ORCPT ); Mon, 7 Dec 2015 18:36:27 -0500 MIME-Version: 1.0 In-Reply-To: <1449529586.7162.10.camel@perches.com> References: <1449529586.7162.10.camel@perches.com> Date: Mon, 7 Dec 2015 20:36:27 -0300 Message-ID: Subject: Re: [BUG] checkpatch: unescaped left brace in regex is deprecated From: "Geyslan G. Bem" To: Joe Perches Cc: Robo Bot , LKML , Peter Senna Tschudin Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2287 Lines: 76 2015-12-07 20:06 GMT-03:00 Joe Perches : > On Mon, 2015-12-07 at 19:53 -0300, Geyslan G. Bem wrote: >> Hello, > > hello. > >> Follow checkpatch output using perl 5.22.0. >> >> geyslan@hb ~/Projects/linux $ scripts/checkpatch.pl -f >> drivers/usb/host/ehci-hub.c >> Unescaped left brace in regex is deprecated, passed through in regex; >> marked by <-- HERE in m/\((?^x: >> > > No HERE here. Are you using linux-next? Yep, geyslan@hb ~/Projects/linux $ git branch -a * (HEAD detached from linux-next/master) ... geyslan@hb ~/Projects/linux $ git remote update Fetching linux Fetching linux-next Fetching linux-staging > > There have been patches applied for this warning already. > > see: > > commit 4e5d56bdf892e18832a6540b63ebf709966bce2a > Author: Eddie Kovsky > Date: Wed Sep 9 15:37:52 2015 -0700 > > checkpatch: fix left brace warning > > Using checkpatch.pl with Perl 5.22.0 generates the following warning: > > Unescaped left brace in regex is deprecated, passed through in regex; > 5. Indeed. But here the error continues. geyslan@hb ~/Projects/linux $ git log 4e5d56bdf892e -1 commit 4e5d56bdf892e18832a6540b63ebf709966bce2a Author: Eddie Kovsky Date: Wed Sep 9 15:37:52 2015 -0700 checkpatch: fix left brace warning Using checkpatch.pl with Perl 5.22.0 generates the following warning: ... geyslan@hb ~/Projects/linux $ git blame scripts/checkpatch.pl | grep 4e5d56b 3599:4e5d56bdf89 (Eddie Kovsky 2015-09-09 15:37:52 -0700 3599) !($line=~/\#\s*define.*do\s\{/) and !($line=~/}/)) { 4111:4e5d56bdf89 (Eddie Kovsky 2015-09-09 15:37:52 -0700 4111) if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\){/) || 4112:4e5d56bdf89 (Eddie Kovsky 2015-09-09 15:37:52 -0700 4112) $line =~ /do\{/) { 4589:4e5d56bdf89 (Eddie Kovsky 2015-09-09 15:37:52 -0700 4589) $dstat !~ /^\(\{/ && # ({... It missed some regexes, maybe? -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/