Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 5 Mar 2003 10:01:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 5 Mar 2003 10:01:17 -0500 Received: from pizda.ninka.net ([216.101.162.242]:58041 "EHLO pizda.ninka.net") by vger.kernel.org with ESMTP id ; Wed, 5 Mar 2003 10:01:16 -0500 Date: Wed, 05 Mar 2003 06:53:41 -0800 (PST) Message-Id: <20030305.065341.35361286.davem@redhat.com> To: chas@locutus.cmf.nrl.navy.mil Cc: wa@almesberger.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH][ATM] make atm (and clip) modular + try_module_get() From: "David S. Miller" In-Reply-To: <200303051508.h25F8gGi006299@locutus.cmf.nrl.navy.mil> References: <20030305.063158.53514369.davem@redhat.com> <200303051508.h25F8gGi006299@locutus.cmf.nrl.navy.mil> X-FalunGong: Information control. X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 21 From: chas williams Date: Wed, 05 Mar 2003 10:08:42 -0500 In message <20030305.063158.53514369.davem@redhat.com>,"David S. Miller" writes : >If you own both objects, why lock anything? i believe the original intent was to prevent anyone else from appending to either of the lists while the lists are being joined. while it would be slightly less efficient, should it use the skb primitives? this is quite a bit easier to read: I understand why you think you have to lock, that isn't the issue. I'm telling you that you should be locking this crap at a much higher level. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/