Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932488AbbLHBlm (ORCPT ); Mon, 7 Dec 2015 20:41:42 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:33294 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932193AbbLHBll (ORCPT ); Mon, 7 Dec 2015 20:41:41 -0500 MIME-Version: 1.0 In-Reply-To: References: <1449107584-3192-1-git-send-email-jwerner@chromium.org> <5664E1CF.8030406@rock-chips.com> <5664F837.607@rock-chips.com> Date: Mon, 7 Dec 2015 17:41:39 -0800 X-Google-Sender-Auth: 3qi1LbrkRBcvKjbD9OdlQSdt8CE Message-ID: Subject: Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st From: Julius Werner To: Doug Anderson Cc: Julius Werner , Chris Zhong , Andrew Morton , Alessandro Zummo , Sonny Rao , Heiko Stuebner , "linux-kernel@vger.kernel.org" , rtc-linux@googlegroups.com, Alexandre Belloni Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 24 > Technically you could still implement this and if firmware happens to > read the RTC (and doesn't correct things) then we won't be able to > correct things. ...but certainly if you read the old time and then > the new time and the old time was < 11/31 and the new time was >= > 11/31 you know you need to correct. > > I'd say that there's a good chance that other firmware (UBoot) doesn't > actually read the RTC anyway. Why would it? We only do it for even > log, right? Hah! Sounds like you assume U-Boot was doing the things it does with comprehensible reasoning. From my experience, that's a dangerous wager (not that I'm biased or anything... ;) ). FWIW, they seem to be having a huge (175kloc, of only the finest copied kernel code from 10+ years ago, I presume) repository of RTC drivers, a separate command line command to read/write to it, and an SNTP client. Still, you're right that adding the GET_TIME check wouldn't hurt... at worst it just does nothing. I'll try it out. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/