Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932843AbbLHFOG (ORCPT ); Tue, 8 Dec 2015 00:14:06 -0500 Received: from terminus.zytor.com ([198.137.202.10]:51164 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbbLHFOE (ORCPT ); Tue, 8 Dec 2015 00:14:04 -0500 Date: Mon, 7 Dec 2015 21:13:37 -0800 From: tip-bot for Wang Nan Message-ID: Cc: hpa@zytor.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org, lizefan@huawei.com, namhyung@kernel.org, tglx@linutronix.de, mingo@kernel.org, acme@redhat.com Reply-To: tglx@linutronix.de, namhyung@kernel.org, acme@redhat.com, mingo@kernel.org, wangnan0@huawei.com, linux-kernel@vger.kernel.org, hpa@zytor.com, lizefan@huawei.com In-Reply-To: <1449455746-41952-4-git-send-email-wangnan0@huawei.com> References: <1449455746-41952-4-git-send-email-wangnan0@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf hists browser: Reset selection when refresh Git-Commit-ID: 979d2cac1144da6b25334a8572c80cde9662105c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2108 Lines: 58 Commit-ID: 979d2cac1144da6b25334a8572c80cde9662105c Gitweb: http://git.kernel.org/tip/979d2cac1144da6b25334a8572c80cde9662105c Author: Wang Nan AuthorDate: Mon, 7 Dec 2015 02:35:46 +0000 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 7 Dec 2015 12:02:12 -0300 perf hists browser: Reset selection when refresh With the following steps: Step 1: perf report Step 2: Use UP/DOWN to select an entry, don't press 'ENTER' Step 3: Use '/' to filter symbols, use a filter which returns empty result Step 4: Press 'ENTER' We see that, even if we have filtered all the symbols (and the main interface is empty), pressing 'ENTER' still selects one symbol. This behavior surprises the user. This patch resets browser->{he_,}selection in hist_browser__refresh() and lets it choose default selection. In this case browser->{he_,}selection keeps NULL so user won't see annotation item in menu. Signed-off-by: Wang Nan Acked-by: Namhyung Kim Tested-by: Arnaldo Carvalho de Melo Cc: Zefan Li Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1449455746-41952-4-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/hists.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 932e13d..84c8251 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -928,6 +928,8 @@ static unsigned int hist_browser__refresh(struct ui_browser *browser) } ui_browser__hists_init_top(browser); + hb->he_selection = NULL; + hb->selection = NULL; for (nd = browser->top; nd; nd = rb_next(nd)) { struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/