Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932927AbbLHGDb (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Dec 2015 01:03:31 -0500
Received: from relmlor2.renesas.com ([210.160.252.172]:16630 "EHLO
	relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751475AbbLHGDV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Dec 2015 01:03:21 -0500
X-IronPort-AV: E=Sophos;i="5.20,398,1444662000"; 
   d="scan'208";a="201321848"
Message-ID: <566672A5.5090905@rvc.renesas.com>
Date: Tue, 8 Dec 2015 13:03:17 +0700
From: Khiem Nguyen <khiem.nguyen.xt@rvc.renesas.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
CC: Simon <horms@verge.net.au>, Zhang Rui <rui.zhang@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Magnus <magnus.damm@gmail.com>,
        "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Khiem Nguyen <khiem.nguyen.xt@rvc.renesas.com>,
        Toru Oishi <toru.oishi.zj@rvc.renesas.com>,
        "Hien Duy. Dang" <hien.dang.eb@rvc.renesas.com>
Subject: Re: [PATCH 5/8 v4] thermal: rcar: enable to use thermal-zone on DT
References: <87vb895x9d.wl%kuninori.morimoto.gx@renesas.com> <87mvtl5x54.wl%kuninori.morimoto.gx@renesas.com>
In-Reply-To: <87mvtl5x54.wl%kuninori.morimoto.gx@renesas.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 6626
Lines: 201

Hi Morimoto-san,

Sorry for late information in v3.
There's a small mistake in example in DT binding documentation.

Anyway, let's wait for more comments from other developers before fixing it.

On 12/8/2015 12:28 PM, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> This patch enables to use thermal-zone on DT if it was call as
> "renesas,rcar-gen2-thermal".
> Previous style is still supported by "renesas,rcar-thermal".
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v3 -> v4
>
>   - no change
>
>   .../devicetree/bindings/thermal/rcar-thermal.txt   | 37 +++++++++++++++++-
>   drivers/thermal/rcar_thermal.c                     | 44 +++++++++++++++++++---
>   2 files changed, 74 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> index 332e625..601a54d 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> @@ -1,8 +1,9 @@
>   * Renesas R-Car Thermal
>
>   Required properties:
> -- compatible		: "renesas,thermal-<soctype>", "renesas,rcar-thermal"
> -			  as fallback.
> +- compatible		: "renesas,thermal-<soctype>",
> +			   "renesas,rcar-gen2-thermal" (with thermal-zone) or
> +			   "renesas,rcar-thermal" (without thermal-zone) as fallback.
>   			  Examples with soctypes are:
>   			    - "renesas,thermal-r8a73a4" (R-Mobile APE6)
>   			    - "renesas,thermal-r8a7779" (R-Car H1)
> @@ -36,3 +37,35 @@ thermal@e61f0000 {
>   		0xe61f0300 0x38>;
>   	interrupts = <0 69 IRQ_TYPE_LEVEL_HIGH>;
>   };
> +
> +Example (with thermal-zone):
> +
> +thermal-zones {
> +	cpu_thermal: cpu-thermal {
> +		polling-delay-passive	= <1000>;
> +		polling-delay		= <5000>;
> +
> +		thermal-sensors = <&thermal>;
> +
> +		trips {
> +			cpu-crit {
> +				temperature	= <1150000>;

One zero is redundant here. It should be 115000.
Even though this is an example, the value 1150000 millicelcius degree is 
too big for existing R-Car systems :)

> +				hysteresis	= <0>;
> +				type		= "critical";
> +			};
> +		};
> +		cooling-maps {
> +		};
> +	};
> +};
> +
> +thermal: thermal@e61f0000 {
> +	compatible =	"renesas,thermal-r8a7790",
> +			"renesas,rcar-gen2-thermal",
> +			"renesas,rcar-thermal";
> +	reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
> +	interrupts = <0 69 IRQ_TYPE_LEVEL_HIGH>;
> +	clocks = <&mstp5_clks R8A7790_CLK_THERMAL>;
> +	power-domains = <&cpg_clocks>;
> +	#thermal-sensor-cells = <0>;
> +};
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index 40c3ba5..d4d2661 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -23,6 +23,7 @@
>   #include <linux/interrupt.h>
>   #include <linux/io.h>
>   #include <linux/module.h>
> +#include <linux/of_device.h>
>   #include <linux/platform_device.h>
>   #include <linux/pm_runtime.h>
>   #include <linux/reboot.h>
> @@ -81,8 +82,10 @@ struct rcar_thermal_priv {
>   # define rcar_force_update_temp(priv)	0
>   #endif
>
> +#define USE_OF_THERMAL	1
>   static const struct of_device_id rcar_thermal_dt_ids[] = {
>   	{ .compatible = "renesas,rcar-thermal", },
> +	{ .compatible = "renesas,rcar-gen2-thermal", .data = (void *)USE_OF_THERMAL },
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, rcar_thermal_dt_ids);
> @@ -206,9 +209,8 @@ err_out_unlock:
>   	return ret;
>   }
>
> -static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp)
> +static int rcar_thermal_get_current_temp(struct rcar_thermal_priv *priv, int *temp)
>   {
> -	struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
>   	int tmp;
>
>   	if (!rcar_has_irq_support(priv) || rcar_force_update_temp(priv)) {
> @@ -234,6 +236,20 @@ static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp)
>   	return 0;
>   }
>
> +static int rcar_thermal_of_get_temp(void *data, int *temp)
> +{
> +	struct rcar_thermal_priv *priv = data;
> +
> +	return rcar_thermal_get_current_temp(priv, temp);
> +}
> +
> +static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp)
> +{
> +	struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
> +
> +	return rcar_thermal_get_current_temp(priv, temp);
> +}
> +
>   static int rcar_thermal_get_trip_type(struct thermal_zone_device *zone,
>   				      int trip, enum thermal_trip_type *type)
>   {
> @@ -290,6 +306,10 @@ static int rcar_thermal_notify(struct thermal_zone_device *zone,
>   	return 0;
>   }
>
> +static const struct thermal_zone_of_device_ops rcar_thermal_zone_of_ops = {
> +	.get_temp	= rcar_thermal_of_get_temp,
> +};
> +
>   static struct thermal_zone_device_ops rcar_thermal_zone_ops = {
>   	.get_temp	= rcar_thermal_get_temp,
>   	.get_trip_type	= rcar_thermal_get_trip_type,
> @@ -326,14 +346,20 @@ static void rcar_thermal_work(struct work_struct *work)
>
>   	priv = container_of(work, struct rcar_thermal_priv, work.work);
>
> -	rcar_thermal_get_temp(priv->zone, &cctemp);
> +	ret = rcar_thermal_get_current_temp(priv, &cctemp);
> +	if (ret < 0)
> +		return;
> +
>   	ret = rcar_thermal_update_temp(priv);
>   	if (ret < 0)
>   		return;
>
>   	rcar_thermal_irq_enable(priv);
>
> -	rcar_thermal_get_temp(priv->zone, &nctemp);
> +	ret = rcar_thermal_get_current_temp(priv, &nctemp);
> +	if (ret < 0)
> +		return;
> +
>   	if (nctemp != cctemp)
>   		thermal_zone_device_update(priv->zone);
>   }
> @@ -394,6 +420,8 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>   	struct rcar_thermal_priv *priv;
>   	struct device *dev = &pdev->dev;
>   	struct resource *res, *irq;
> +	const struct of_device_id *of_id = of_match_device(rcar_thermal_dt_ids, dev);
> +	unsigned long of_data = (unsigned long)of_id->data;
>   	int mres = 0;
>   	int i;
>   	int ret = -ENODEV;
> @@ -452,7 +480,13 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>   		if (ret < 0)
>   			goto error_unregister;
>
> -		priv->zone = thermal_zone_device_register("rcar_thermal",
> +		if (of_data == USE_OF_THERMAL)
> +			priv->zone = thermal_zone_of_sensor_register(
> +						dev, i, priv,
> +						&rcar_thermal_zone_of_ops);
> +		else
> +			priv->zone = thermal_zone_device_register(
> +						"rcar_thermal",
>   						1, 0, priv,
>   						&rcar_thermal_zone_ops, NULL, 0,
>   						idle);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/