Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756109AbbLHIc1 (ORCPT ); Tue, 8 Dec 2015 03:32:27 -0500 Received: from down.free-electrons.com ([37.187.137.238]:58489 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754334AbbLHIc0 (ORCPT ); Tue, 8 Dec 2015 03:32:26 -0500 Date: Tue, 8 Dec 2015 09:32:24 +0100 From: Maxime Ripard To: Jean-Francois Moine Cc: Jens Kuske , Chen-Yu Tsai , Rob Herring , Michael Turquette , Stephen Boyd , Linus Walleij , devicetree@vger.kernel.org, Vishnu Patekar , Emilio =?iso-8859-1?Q?L=F3pez?= , Reinder de Haan , linux-kernel@vger.kernel.org, Hans de Goede , linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 3/4] ARM: dts: sunxi: Add Allwinner H3 DTSI Message-ID: <20151208083224.GN27957@lukather> References: <1449264283-25360-1-git-send-email-jenskuske@gmail.com> <1449264283-25360-4-git-send-email-jenskuske@gmail.com> <20151207091257.070723b67db726d9f05c6550@free.fr> <5665D38E.4050406@gmail.com> <20151208090658.e471fcde7fd5e79c69706115@free.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wmhq21yAGFMoSpeN" Content-Disposition: inline In-Reply-To: <20151208090658.e471fcde7fd5e79c69706115@free.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3214 Lines: 85 --wmhq21yAGFMoSpeN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 08, 2015 at 09:06:58AM +0100, Jean-Francois Moine wrote: > On Mon, 7 Dec 2015 19:44:30 +0100 > Jens Kuske wrote: >=20 > > >> + "bus_lcd0", "bus_lcd1", "bus_deint", > >=20 > > > "bus_tcon0", "bus_tcon1", "bus_deint", > > >=20 > > > (the tcon1 clock is used by both lcd0 and lcd1, while > > > the tcon0 clock is used for TV output from lcd1) > >=20 > > Hi, > >=20 > > These are only the ahb bus gates, not the module clocks. > > Naming them lcd might be a bit confusing, but it follows the naming we > > used since sun4i. And the tcon modules are still called lcd0 and lcd1 > > module in the manual too. >=20 > There is no reference to TCON0 in the LCDs registers (H3 V1.1 pages 428 > and 435), only TCON1. >=20 > > Interestingly there is only a tcon0 module clock in the manual and no > > tcon1, but that is not part of this patch. >=20 > Well, I looked again in the 3.4 kernel and, for the LCD0/HDMI, there is > no clock setting for TCON1: it just receives the AHB1 clock. >=20 > This means that its gate ("bus_lcd1" or "ahb1_tcon1") must be enabled > when streaming on LCD0 or LCD1. >=20 > The role of tcon0 is not yet clear to me, but it seems that its clock > is the streaming clock for LCD1/TV, as the HDMI clock is for LCD0/HDMI. If the H3 display block is done the same way than the A10 (and later) one on this aspect, then the TCON has two channels with two different streaming (or functional, you pick the name) clocks. The channel 0 is usually used for RGB, the channel 1 for HDMI, composite and VGA. Maybe they just added different bus gates for those two different channels, and moved HDMI to the channel 0. Anyway, that can always be changed later on if we have more clue on what's going on. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --wmhq21yAGFMoSpeN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWZpWYAAoJEBx+YmzsjxAgHRgQAKJcahtv+adEAv+tjkXnvREk ieLCs08ocbmXc7SADKc+d9cpL/0kC0Nbt9DrPuyqw6YQSgCxBKGpZIOc/+3QpBIp HW+zzH+CEg+1wi8LDHhqzjMK1vFrutr/fygYna6g/P3hWeHKx5bFgfcAGm14yRx3 f8gVgwHS9gK4Hx+eNqQeJtadfDqBLvoMkAOiMOVcChZtK4On1hf+kf8Gcg8ftq38 1CovQ1p+K84PtZzVxnWzX+8pxdY95FXP3i4YcwwNjkKW3qzVTVnw6P++iwt1/mDT FZU4LqiOTQbUrFo6//eh3KT8d7tmErwbA2LXA/B9F+/Opt8agbvG8XzCqvN6eSNv uIgWnWGKnYH0DccQIAXPoqc4omDUeUXdGbOcGByGWxIaq0I6idNOoE6iskbRh8fh +fZ7Ycerr4UGL35e2faNQB8lJ92KX0abGZdb/L++XjCFB7EUc143/LnMs8bV3U1x /habjWY2dAsbMhyyICrXcOuV6cozKO1Y/wwobvVFYg8ClOILxGBL3hQ2yDVPaZqq 7wtgrAEO5keTZYT7hkWCxGerKbvZ44gh+faI01YhxsM+YH8rEoS5yLALoZA5Rynt j+aUwn21woR7Nzvz9UQV7nuFua/Eoy/kWjJA0woiNI58lH+sUY4/S8LLHpl98WgS V7IJ+6l2sdLGF+2CzjUC =XGXY -----END PGP SIGNATURE----- --wmhq21yAGFMoSpeN-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/