Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964848AbbLHKJ3 (ORCPT ); Tue, 8 Dec 2015 05:09:29 -0500 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:38977 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933004AbbLHKJ1 convert rfc822-to-8bit (ORCPT ); Tue, 8 Dec 2015 05:09:27 -0500 Subject: Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error To: Al Viro , Linus Torvalds References: <1449511503-7543-1-git-send-email-suzuki.poulose@arm.com> <20151208075854.GN20997@ZenIV.linux.org.uk> Cc: Linux Kernel Mailing List , linux-fsdevel , Marc Zyngier , Tejun Heo , stable From: "Suzuki K. Poulose" Message-ID: <5666AC38.8050806@arm.com> Date: Tue, 8 Dec 2015 10:08:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151208075854.GN20997@ZenIV.linux.org.uk> X-OriginalArrivalTime: 08 Dec 2015 10:08:56.0660 (UTC) FILETIME=[73222140:01D131A0] X-MC-Unique: -BsK2lAkQB2YVZxf0S-rGQ-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 44 On 08/12/15 07:58, Al Viro wrote: > On Mon, Dec 07, 2015 at 10:49:05AM -0800, Linus Torvalds wrote: >> On Mon, Dec 7, 2015 at 10:05 AM, Suzuki K. Poulose >> wrote: ... > Anyway, the fix for 9p bogosity follows; it definitely fixes a bug there, > and I'm fairly sure that it fixes the bug that had been reported. > A confirmation would be nice, of course... > > Signed-off-by: Al Viro > --- > diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c > index 699941e..5110785 100644 > --- a/fs/9p/vfs_inode.c > +++ b/fs/9p/vfs_inode.c > @@ -451,9 +451,9 @@ void v9fs_evict_inode(struct inode *inode) > { > struct v9fs_inode *v9inode = V9FS_I(inode); > > - truncate_inode_pages_final(inode->i_mapping); > + truncate_inode_pages_final(&inode->i_data); > clear_inode(inode); > - filemap_fdatawrite(inode->i_mapping); > + filemap_fdatawrite(&inode->i_data); > > v9fs_cache_inode_put_cookie(inode); > /* clunk the fid stashed in writeback_fid */ > This patch fixes the problem : Tested-by: Suzuki K. Poulose Thanks Suzuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/