Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933348AbbLHKdu (ORCPT ); Tue, 8 Dec 2015 05:33:50 -0500 Received: from down.free-electrons.com ([37.187.137.238]:33764 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932267AbbLHKds (ORCPT ); Tue, 8 Dec 2015 05:33:48 -0500 Date: Tue, 8 Dec 2015 11:33:43 +0100 From: Boris Brezillon To: Harvey Hunt Cc: David Woodhouse , Brian Norris , , Daniel Mack , Haojian Zhuang , Robert Jarzmik , "Kukjin Kim" , Krzysztof Kozlowski , , , Ralf Baechle , , Josh Wu , Ezequiel Garcia , Maxime Ripard , Chen-Yu Tsai , , Stefan Agner , Kyungmin Park , "Greg Kroah-Hartman" , , , punnaiah choudary kalluri Subject: Re: [PATCH 05/23] mtd: nand: jz4770: kill the ->ecc_layout field Message-ID: <20151208113343.2b049993@bbrezillon> In-Reply-To: <5666B150.2030406@imgtec.com> References: <1449527178-5930-1-git-send-email-boris.brezillon@free-electrons.com> <1449527178-5930-6-git-send-email-boris.brezillon@free-electrons.com> <5666B150.2030406@imgtec.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2281 Lines: 65 On Tue, 8 Dec 2015 10:30:40 +0000 Harvey Hunt wrote: > Hi Boris, > > On 07/12/15 22:26, Boris Brezillon wrote: > > ->ecc_layout is not used by any board file. Kill this field to avoid any > > confusion. New boards are encouraged to use the default ECC layout defined > > in NAND core. > > > > Signed-off-by: Boris Brezillon > > --- > > arch/mips/include/asm/mach-jz4740/jz4740_nand.h | 2 -- > > drivers/mtd/nand/jz4740_nand.c | 3 --- > > 2 files changed, 5 deletions(-) > > > > diff --git a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > > index 79cff26..398733e 100644 > > --- a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > > +++ b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > > @@ -25,8 +25,6 @@ struct jz_nand_platform_data { > > int num_partitions; > > struct mtd_partition *partitions; > > > > - struct nand_ecclayout *ecc_layout; > > - > > unsigned char banks[JZ_NAND_NUM_BANKS]; > > > > void (*ident_callback)(struct platform_device *, struct nand_chip *, > > diff --git a/drivers/mtd/nand/jz4740_nand.c b/drivers/mtd/nand/jz4740_nand.c > > index 5a99a93..c4fe446 100644 > > --- a/drivers/mtd/nand/jz4740_nand.c > > +++ b/drivers/mtd/nand/jz4740_nand.c > > @@ -446,9 +446,6 @@ static int jz_nand_probe(struct platform_device *pdev) > > chip->ecc.bytes = 9; > > chip->ecc.strength = 4; > > > > - if (pdata) > > - chip->ecc.layout = pdata->ecc_layout; > > - > > chip->chip_delay = 50; > > chip->cmd_ctrl = jz_nand_cmd_ctrl; > > chip->select_chip = jz_nand_select_chip; > > > > Is there a typo in this commit title? The JZ4740 and JZ4770 have quite > different NAND controller interfaces, so I don't think that the JZ4740 > driver will support the JZ4770. Yes, it's a typo, I meant jz4740, I'll fix my commit message accordingly. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/