Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756159AbbLHLUe (ORCPT ); Tue, 8 Dec 2015 06:20:34 -0500 Received: from mail-bn1on0141.outbound.protection.outlook.com ([157.56.110.141]:64736 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754814AbbLHLUc convert rfc822-to-8bit (ORCPT ); Tue, 8 Dec 2015 06:20:32 -0500 From: Liberman Igal To: David Miller CC: "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Scott Wood , Madalin-Cristian Bucur , "pebolle@tiscali.nl" , "joakim.tjernlund@transmode.se" , "ppc@mindchasers.com" , "stephen@networkplumber.org" Subject: RE: [v9, 3/6] fsl/fman: Add FMan MAC support Thread-Topic: [v9, 3/6] fsl/fman: Add FMan MAC support Thread-Index: AQHRLbsjpUdMLJR8TUiY7PQ7GE9Ve565tYoAgAdDhBA= Date: Tue, 8 Dec 2015 11:20:28 +0000 Message-ID: References: <1449127157-9400-1-git-send-email-igal.liberman@freescale.com> <1449127157-9400-4-git-send-email-igal.liberman@freescale.com> <20151203.152342.830757781812463540.davem@davemloft.net> In-Reply-To: <20151203.152342.830757781812463540.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igal.Liberman@freescale.com; x-originating-ip: [192.88.162.1] x-microsoft-exchange-diagnostics: 1;BY1PR03MB1482;5:aZHegxgWBqqWD0oN9uY5qW8/dXDqb93tF14NORP6Fg+UH27HxjWjDKxqqkNqHY6MvUIFoYjDZ+ps0Kc2l0PafvNtV8QgwADVoRbRQmhscDMl5waFWCxPnN8tgS9FHKwkhHCocFU9iCDEm7FBmfk8+A==;24:yNRKofQWFS3lToycKNr3J5Z8gfRHWcR1cihb2BfZTAX1aZmKKqp2hNIxhVT9tAoDTIfIc9wTf7VG0nClpN6vTGf2XM+7U462nm18HHddEGs= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; x-forefront-prvs: 0784C803FD x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(13464003)(199003)(189002)(5001960100002)(86362001)(5002640100001)(5008740100001)(10400500002)(122556002)(5003600100002)(81156007)(19580405001)(3846002)(74316001)(5004730100002)(19580395003)(102836003)(586003)(11100500001)(1220700001)(1096002)(76176999)(50986999)(54356999)(40100003)(6116002)(105586002)(87936001)(106116001)(2950100001)(99286002)(33656002)(101416001)(106356001)(189998001)(77096005)(2900100001)(97736004)(92566002)(110136002)(76576001)(66066001)(19627235001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:DM2PR03MB509.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2015 11:20:28.9587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1152 Lines: 34 Regards, Igal Liberman > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Thursday, December 03, 2015 10:24 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > kernel@vger.kernel.org; Wood Scott-B07421 ; > Bucur Madalin-Cristian-B32716 ; > pebolle@tiscali.nl; joakim.tjernlund@transmode.se; ppc@mindchasers.com; > stephen@networkplumber.org > Subject: Re: [v9, 3/6] fsl/fman: Add FMan MAC support > > From: > Date: Thu, 3 Dec 2015 09:19:14 +0200 > > > +static u32 crc_table[256] = { > > No way. > > We have every conceivable implementation of CRC calculations in the kernel > already. Use them. OK, I will remove the private implementation of CRC calculation in the next submission. Thank you. Igal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/