Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964925AbbLHL4Z (ORCPT ); Tue, 8 Dec 2015 06:56:25 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:33777 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932632AbbLHL4X (ORCPT ); Tue, 8 Dec 2015 06:56:23 -0500 MIME-Version: 1.0 In-Reply-To: <5666AC38.8050806@arm.com> References: <1449511503-7543-1-git-send-email-suzuki.poulose@arm.com> <20151208075854.GN20997@ZenIV.linux.org.uk> <5666AC38.8050806@arm.com> Date: Tue, 8 Dec 2015 12:56:22 +0100 Message-ID: Subject: Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error From: Vegard Nossum To: "Suzuki K. Poulose" Cc: Al Viro , Linus Torvalds , Linux Kernel Mailing List , linux-fsdevel , Marc Zyngier , Tejun Heo , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1680 Lines: 55 On 8 December 2015 at 11:08, Suzuki K. Poulose wrote: > On 08/12/15 07:58, Al Viro wrote: >> >> On Mon, Dec 07, 2015 at 10:49:05AM -0800, Linus Torvalds wrote: >>> >>> On Mon, Dec 7, 2015 at 10:05 AM, Suzuki K. Poulose >>> wrote: > > > ... > >> Anyway, the fix for 9p bogosity follows; it definitely fixes a bug there, >> and I'm fairly sure that it fixes the bug that had been reported. >> A confirmation would be nice, of course... >> >> Signed-off-by: Al Viro >> --- >> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c >> index 699941e..5110785 100644 >> --- a/fs/9p/vfs_inode.c >> +++ b/fs/9p/vfs_inode.c >> @@ -451,9 +451,9 @@ void v9fs_evict_inode(struct inode *inode) >> { >> struct v9fs_inode *v9inode = V9FS_I(inode); >> >> - truncate_inode_pages_final(inode->i_mapping); >> + truncate_inode_pages_final(&inode->i_data); >> clear_inode(inode); >> - filemap_fdatawrite(inode->i_mapping); >> + filemap_fdatawrite(&inode->i_data); >> >> v9fs_cache_inode_put_cookie(inode); >> /* clunk the fid stashed in writeback_fid */ >> > > This patch fixes the problem : > > Tested-by: Suzuki K. Poulose > > Thanks > Suzuki FWIW, I think I reported the same issue here: http://sourceforge.net/p/v9fs/mailman/message/34661239/ And Al's patch fixed it here too. Thanks, Vegard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/