Subject: Re: [PATCH] MIPS: VDSO: Fix build error
To: Qais Yousef <qais.yousef@imgtec.com>, linux-mips@linux-mips.org
References: <1449569503-1611-1-git-send-email-qais.yousef@imgtec.com>
Cc: alex@alex-smith.me.uk, linux-kernel@vger.kernel.org, ralf@linux-mips.org
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <5666C8B2.2030402@cogentembedded.com>
Date: Tue, 8 Dec 2015 15:10:26 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1449569503-1611-1-git-send-email-qais.yousef@imgtec.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1210
Lines: 34

Hello.

On 12/8/2015 1:11 PM, Qais Yousef wrote:

> Commit ebb5e78cc634 (MIPS: Initial implementation of a VDSO) introduced a build
> error.

    scripts/checkpatch.pl now enforces certain format for the commit citing -- 
you also need to enclose the summary in "".

> For MIPS VDSO to be compiled it requires binutils version 2.25 or above but the
> check in the Makefile had inverted logic causing it to be compiled in if binutils
> is below 2.25.
>
> This fixes the following compilation error:
>
> CC      arch/mips/vdso/gettimeofday.o
> /tmp/ccsExcUd.s: Assembler messages:
> /tmp/ccsExcUd.s:62: Error: can't resolve `_start' {*UND* section} - `L0' {.text section}
> /tmp/ccsExcUd.s:467: Error: can't resolve `_start' {*UND* section} - `L0' {.text section}
> make[2]: *** [arch/mips/vdso/gettimeofday.o] Error 1
> make[1]: *** [arch/mips/vdso] Error 2
> make: *** [arch/mips] Error 2
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/