Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756170AbbLHMjh (ORCPT ); Tue, 8 Dec 2015 07:39:37 -0500 Received: from rtits2.realtek.com ([60.250.210.242]:59016 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755129AbbLHMjf convert rfc822-to-8bit (ORCPT ); Tue, 8 Dec 2015 07:39:35 -0500 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID tB8CdCK0027558, This message is accepted by code: ctloc85258 From: Hayes Wang To: Peter Wu , "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Lu Baolu Subject: RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled Thread-Topic: [PATCH v2] r8152: fix lockup when runtime PM is enabled Thread-Index: AQHRMaoYnf1SY6s5ykW+Hxk1Ou29D57BBqoA Date: Tue, 8 Dec 2015 12:39:12 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2F8DAD9@RTITMBSV03.realtek.com.tw> References: <1449573462-28417-1-git-send-email-peter@lekensteyn.nl> In-Reply-To: <1449573462-28417-1-git-send-email-peter@lekensteyn.nl> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.71.143] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 35 Peter Wu [mailto:peter@lekensteyn.nl] > Sent: Tuesday, December 08, 2015 7:18 PM > > When an interface is brought up which was previously suspended (via > runtime PM), it would hang. This happens because napi_disable is called > before napi_enable. > > Solve this by avoiding napi_enable in the resume during open function > (netif_running is true when open is called, IFF_UP is set after a > successful open; netif_running is false when close is called, but IFF_UP > is then still set). > > While at it, remove WORK_ENABLE check from rtl8152_open (introduced with > the original change) because it cannot happen: > > - After this patch, runtime resume will not set it during rtl8152_open. > - When link is up, rtl8152_open is not called. > - When link is down during system/auto suspend/resume, it is not set. > > Fixes: 41cec84cf285 ("r8152: don't enable napi before rx ready") > Link: https://lkml.kernel.org/r/20151205105912.GA1766@al > Signed-off-by: Peter Wu > --- > v2: moved rtl_runtime_suspend_enable from close to rtl8152_suspend Acked-by: Hayes Wang Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/