Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756353AbbLHNJM (ORCPT ); Tue, 8 Dec 2015 08:09:12 -0500 Received: from erouter8.ore.mailhop.org ([54.187.218.212]:36794 "EHLO erouter8.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756098AbbLHNJK (ORCPT ); Tue, 8 Dec 2015 08:09:10 -0500 X-DKIM: OpenDKIM Filter v2.6.8 io F0EAB8001B Date: Tue, 8 Dec 2015 13:09:05 +0000 From: Jason Cooper To: Sanidhya Solanki Cc: gregkh@linuxfoundation.org, mathieu.poirier@linaro.org, deepa.kernel@gmail.com, brcnakalin@gmail.com, vatikaharlalka@gmail.com, sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file. Message-ID: <20151208130905.GX6520@io.lakedaemon.net> References: <1449542244-637-1-git-send-email-jpage.lkml@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449542244-637-1-git-send-email-jpage.lkml@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3216 Lines: 95 Sanidhya, *Much* better. Only two two small nits (things which Greg may be able to fix up when applying), and one comment. nit: Patch subject should be 'staging: skein: ...' On Mon, Dec 07, 2015 at 09:37:24PM -0500, Sanidhya Solanki wrote: > The original code defined macros in the source code, making it > harder to read. Moved them to the header file, as per the TODO file. > > Upadated the TODO file. nit: typo 'Updated' > > Signed-off-by: Sanidhya Solanki > --- > drivers/staging/skein/TODO | 1 - > drivers/staging/skein/skein_block.c | 6 ------ > drivers/staging/skein/skein_block.h | 7 +++++++ > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO > index cd3508d..e3de0c7 100644 > --- a/drivers/staging/skein/TODO > +++ b/drivers/staging/skein/TODO > @@ -1,6 +1,5 @@ > skein/threefish TODO > > - - move macros into appropriate header files There are a lot more macros to relocate than what we see below. I'd prefer to edit the TODO only after it's all cleaned up. Sorry if I wasn't clear before. I was assuming previous versions of your patches were tests, and that once you had the process down, you'd hit all of the macros. So, the question is: Would you like this to be the first patch so you can see the whole process once? If so, we need to leave the TODO item intact. Otherwise, I think you've got the whole submission process down now so you can go ahead and do all the macros. Just let us know. thx, Jason. > - add / pass test vectors > - module support > > diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c > index 45b4732..2120392 100644 > --- a/drivers/staging/skein/skein_block.c > +++ b/drivers/staging/skein/skein_block.c > @@ -26,12 +26,6 @@ > #define SKEIN_LOOP 001 /* default: unroll 256 and 512, but not 1024 */ > #endif > > -#define BLK_BITS (WCNT * 64) /* some useful definitions for code here */ > -#define KW_TWK_BASE (0) > -#define KW_KEY_BASE (3) > -#define ks (kw + KW_KEY_BASE) > -#define ts (kw + KW_TWK_BASE) > - > #ifdef SKEIN_DEBUG > #define debug_save_tweak(ctx) \ > { \ > diff --git a/drivers/staging/skein/skein_block.h b/drivers/staging/skein/skein_block.h > index 9d40f4a..0fd4bfe 100644 > --- a/drivers/staging/skein/skein_block.h > +++ b/drivers/staging/skein/skein_block.h > @@ -7,6 +7,13 @@ > ** This algorithm and source code is released to the public domain. > ** > ************************************************************************/ > + > +#define BLK_BITS (WCNT * 64) /* some useful definitions for code here */ > +#define KW_TWK_BASE (0) > +#define KW_KEY_BASE (3) > +#define ks (kw + KW_KEY_BASE) > +#define ts (kw + KW_TWK_BASE) > + > #ifndef _SKEIN_BLOCK_H_ > #define _SKEIN_BLOCK_H_ > > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/