Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965002AbbLHN4N (ORCPT ); Tue, 8 Dec 2015 08:56:13 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:36790 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755218AbbLHN4M (ORCPT ); Tue, 8 Dec 2015 08:56:12 -0500 Date: Tue, 8 Dec 2015 13:56:07 +0000 From: Lee Jones To: Geert Uytterhoeven Cc: Support Opensource , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: da9063: Allow modular build Message-ID: <20151208135607.GI3384@x1> References: <1449505003-5243-1-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1449505003-5243-1-git-send-email-geert+renesas@glider.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 41 On Mon, 07 Dec 2015, Geert Uytterhoeven wrote: > Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which > allows to decrease size of multi-platform kernels (e.g. > multi_v7_defconfig). > > Signed-off-by: Geert Uytterhoeven > --- > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The DA9063 driver appears to contain all module code. In fact, I'm surprised that it wasn't enabled for tristate in the first place. In any case, it would be good to get a Reviewed/Acked-by from one of the Dialog guys. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 4d92df6ef9fe92ac..527ee7168617c933 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -211,7 +211,7 @@ config MFD_DA9062 > of the device. > > config MFD_DA9063 > - bool "Dialog Semiconductor DA9063 PMIC Support" > + tristate "Dialog Semiconductor DA9063 PMIC Support" > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/