Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964956AbbLHOVT (ORCPT ); Tue, 8 Dec 2015 09:21:19 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:48872 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755329AbbLHOVO (ORCPT ); Tue, 8 Dec 2015 09:21:14 -0500 From: Felipe Balbi To: Gregory CLEMENT CC: , Greg Kroah-Hartman , , , , Subject: Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case In-Reply-To: <874mft9ukx.fsf@free-electrons.com> References: <1440087153-31084-1-git-send-email-gregory.clement@free-electrons.com> <55D719B1.8010700@free-electrons.com> <87twrfsbed.fsf@free-electrons.com> <87d1wtf5ir.fsf@saruman.tx.rr.com> <87a8rde96m.fsf@free-electrons.com> <87poyiegc7.fsf@free-electrons.com> <87poyinjpc.fsf@saruman.tx.rr.com> <874mft9ukx.fsf@free-electrons.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 8 Dec 2015 08:20:45 -0600 Message-ID: <87h9jtm37m.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3057 Lines: 86 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Gregory CLEMENT writes: >>>> if it is the case then it didn't fix the issue I had. >>>> >>>> I activated the following debug line: >>>> >>>> [musb_hdrc]musb_interrupt =3D_ "** IRQ %s usb%04x tx%04x rx%04x\012" >>>> [musb_dsps]dsps_interrupt =3Dp "usbintr (%x) epintr(%x)\012" >>>> >>>> But I didn't get any interrupt while disconnecting the cable without a= ny >>>> device connected on it (whereas I got an interrupt when I connected it= ). >>>> >>>> Note that I applied this patch instead of the "usb: musb: dsps: handle >>>> the otg_state_a_wait_vrise_timeout case", is what you had in mind ? >> >> yeah, that's what I had in mind. But your patch seems wrong :-) >> >> I tried writing a more correct version here and found 2 issues: >> >> a) bit 3 doesn't do anything :-p I cannot read IRQs from mentor's >> registers >> >> b) when setting RESET_ISOLATION bit, reads of CTRL register hang. Note >> that according to TRM, RESET_ISOLATION _must_ be set prior to a soft >> reset and cleared afterwards. But right after setting RESET_ISOLATION, >> if I try a read of CTRL, it'll hang forever. > > The datasheet seems not very coherent about it, > > on one side we have: > "This bit should be set high prior to setting bit 0 and cleared after bit= 0 > is cleared." > > and on the other side: > "Both the soft_reset and soft_reset_isolation bits should be asserted > simultaneously." > > The hang you saw could be explained by the following: > "Setting only the soft_reset_isolation bit will cause all USB0 output > signals to go to a known constant value via multiplexers. > This will > prevent future access to USB0." page 2567 good catch. Setting them together makes the hang go away. I still have the other problem, which is legacy IRQ reporting mode not really working. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWZuc+AAoJEIaOsuA1yqRE6SYP/jww9LF2mZAbaxQmLw0aD8Xg /1QA+PNmFrBHz8CVsOZkMPrwt9wCds3N3DQTVxLxWZykdPjt0cxMHLF0xG4alYUA f/iylwghBhuZPsXvZ5NB+1aqAZw1cv/dzux11oYqOWAPa22ExRN/0BH2ykTUHJ5U +bvSgIpiOv+nMCczFXxSigbc39CJLTj1GjOY8jFctaQAiFmozk0vrxR/KpcIhyId plwDUkuTJ+GjxkvTtIixWrqiYh7a6Hpzw7HGbzgf4J/g0yHftFuBYD6BizXNUxq3 PQuCqKPww3Ko6bWMglXe7o15vbewFqfRlMDnTThh8BPSzTpikLdOOolry2CFcZNz PlgNeq3Ihcxikin58JdRcRhe0AP5hdBkxPVprNcFov37iKSn/lb+bIfx5j6u0k0S WJfRuohC1xImW9QL5y41ShwBUfvafYYdnAAtEY6wSodmivGbvSXCajYYvXZMWTJL cnWCzLItG20Utklio6+gGhD4yWQp3ggCDGSr5+ojy/okIGCs0Vi3cp6IfDn314mv cwZfxpNh6Y3dEPp4mkyl7Q6LdSkTlDuVnIvN5EJtXEToBD+wJMtdArJQI/pAdPIt 48VaFMql0IenvZX3G9GIEkvYU3YEyVvKjBy4lylFUM9/JDO8a8+3gVZbtnje+HCs zj4Jh+XMbVK3PMDq8waF =LHyl -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/