Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933221AbbLHPZF (ORCPT ); Tue, 8 Dec 2015 10:25:05 -0500 Received: from m50-135.163.com ([123.125.50.135]:54225 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932665AbbLHPZC (ORCPT ); Tue, 8 Dec 2015 10:25:02 -0500 From: Geliang Tang To: Andrew Morton , Rasmus Villemoes , Vyacheslav Dubeyko Cc: Geliang Tang , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hfs: use list_for_each_entry in hfs_cat_delete Date: Tue, 8 Dec 2015 23:22:56 +0800 Message-Id: X-Mailer: git-send-email 2.5.0 X-CM-TRANSID: D9GowACnTqvS9WZWFTUMAA--.5651S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF48KFWxZw47JFWftr13Jwb_yoWDZrg_ur WIkF97Gr45tF4Skry5KwnagF98Xw4UJFn5Crs2yF93JF9xGwn5Zayqv393ZrZ5Ww4ft3Wr W34DJryrGF10gjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjco2UUUUUU== X-Originating-IP: [116.77.139.106] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiGRTKmVXlPw-lWwAAsg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 41 Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang --- fs/hfs/catalog.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c index db458ee..1eb5d41 100644 --- a/fs/hfs/catalog.c +++ b/fs/hfs/catalog.c @@ -214,7 +214,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str) { struct super_block *sb; struct hfs_find_data fd; - struct list_head *pos; + struct hfs_readdir_data *rd; int res, type; hfs_dbg(CAT_MOD, "delete_cat: %s,%u\n", str ? str->name : NULL, cnid); @@ -240,9 +240,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str) } } - list_for_each(pos, &HFS_I(dir)->open_dir_list) { - struct hfs_readdir_data *rd = - list_entry(pos, struct hfs_readdir_data, list); + list_for_each_entry(rd, &HFS_I(dir)->open_dir_list, list) { if (fd.tree->keycmp(fd.search_key, (void *)&rd->key) < 0) rd->file->f_pos--; } -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/