Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933482AbbLHQaa (ORCPT ); Tue, 8 Dec 2015 11:30:30 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:38296 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932402AbbLHQa2 (ORCPT ); Tue, 8 Dec 2015 11:30:28 -0500 Date: Tue, 8 Dec 2015 16:30:21 +0000 From: Charles Keepax To: Rasmus Villemoes CC: Lee Jones , , Subject: Re: [PATCH] mfd: wm831x: fix broken wm831x_unique_id_show Message-ID: <20151208163021.GF6058@localhost.localdomain> References: <1449358779-19066-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1449358779-19066-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1512080286 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 21 On Sun, Dec 06, 2015 at 12:39:39AM +0100, Rasmus Villemoes wrote: > wm831x_unique_id_show currently displays an interesting pattern of '0' > and '3' characters which isn't very useful (figuring out why is left > as an exercise for the reader). Presumably "buf[i]" should have been > "id[i] & 0xff". > > But while there, it is much simpler to simply use %phN and do all the > formatting at once. > > Signed-off-by: Rasmus Villemoes > --- Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/