Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750990AbbLHQy1 (ORCPT ); Tue, 8 Dec 2015 11:54:27 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:34532 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbbLHQy0 (ORCPT ); Tue, 8 Dec 2015 11:54:26 -0500 Subject: Re: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing To: Arnd Bergmann , Murali Karicheri References: <2560281.KhcNzi0XgD@wuerfel> Cc: Santosh Shilimkar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Kwok, WingMan" From: santosh shilimkar Organization: Oracle Corporation Message-ID: <56670B21.5060209@oracle.com> Date: Tue, 8 Dec 2015 08:53:53 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <2560281.KhcNzi0XgD@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2136 Lines: 44 On 12/8/2015 7:30 AM, Arnd Bergmann wrote: > The knav_qmss driver is currently broken when CONFIG_LPAE is > set, which is a bit surprising because I'd expect that any serious > users of this platforms would have more than 2GB of RAM and require > LPAE. > Well it has been working with LPAE enable always. The production systems do but IIRC, some of the Eval board were still build with just 2 GB memory. > The compiler clearly warns about an incorrect use of dma_addr_t > in the debug kernel messages: > > ti/knav_qmss_queue.c: In function 'knav_queue_setup_region': > ti/knav_qmss_queue.c:1025:117: warning: format '%x' expects argument of type 'unsigned int', but argument 9 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > ti/knav_qmss_queue.c:1025:117: warning: format '%x' expects argument of type 'unsigned int', but argument 10 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > ti/knav_qmss_queue.c: In function 'knav_queue_setup_link_ram': > ti/knav_qmss_queue.c:1175:118: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > %x should have been %llx or %pad as your patch does now. > This patch changes all the debugging output to use the correct > %pad format string that works with both 32-bit and 64-bit dma_addr_t. > As the variable naming is somewhat confusing here, I also change > all *_phys names to *_dma when they refer to bus addresses that > are used for DMA rather than a physical memory address as seen from > the CPU. This is particularly important on keystone, because the > two things are not the same there. > Right. Rename sounds good. > Signed-off-by: Arnd Bergmann > --- Thanks for the patch Arnd !! Wingman/Murali, Can you guys please test this patch and update the thread ? I will queue this up for next merge window. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/