Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751129AbbLHRMF (ORCPT ); Tue, 8 Dec 2015 12:12:05 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:35561 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbbLHRMD (ORCPT ); Tue, 8 Dec 2015 12:12:03 -0500 Message-ID: <1449594720.2689.1.camel@ubuntu-slavad-14.04> Subject: Re: [PATCH] hfs: use list_for_each_entry in hfs_cat_delete From: Vyacheslav Dubeyko To: Geliang Tang Cc: Andrew Morton , Rasmus Villemoes , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 08 Dec 2015 09:12:00 -0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1469 Lines: 48 On Tue, 2015-12-08 at 23:22 +0800, Geliang Tang wrote: > Use list_for_each_entry() instead of list_for_each() to simplify > the code. > Looks good. Reviewed-by: Vyacheslav Dubeyko Thanks, Vyacheslav Dubeyko. > Signed-off-by: Geliang Tang > --- > fs/hfs/catalog.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c > index db458ee..1eb5d41 100644 > --- a/fs/hfs/catalog.c > +++ b/fs/hfs/catalog.c > @@ -214,7 +214,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str) > { > struct super_block *sb; > struct hfs_find_data fd; > - struct list_head *pos; > + struct hfs_readdir_data *rd; > int res, type; > > hfs_dbg(CAT_MOD, "delete_cat: %s,%u\n", str ? str->name : NULL, cnid); > @@ -240,9 +240,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str) > } > } > > - list_for_each(pos, &HFS_I(dir)->open_dir_list) { > - struct hfs_readdir_data *rd = > - list_entry(pos, struct hfs_readdir_data, list); > + list_for_each_entry(rd, &HFS_I(dir)->open_dir_list, list) { > if (fd.tree->keycmp(fd.search_key, (void *)&rd->key) < 0) > rd->file->f_pos--; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/