Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751238AbbLHRMo (ORCPT ); Tue, 8 Dec 2015 12:12:44 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37890 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbbLHRMm (ORCPT ); Tue, 8 Dec 2015 12:12:42 -0500 Date: Tue, 8 Dec 2015 17:12:35 +0000 From: Mark Brown To: Xiubo Li Cc: linux-kernel@vger.kernel.org Message-ID: <20151208171235.GV5727@sirena.org.uk> References: <1449135113-31892-1-git-send-email-lixiubo@cmss.chinamobile.com> <1449135113-31892-2-git-send-email-lixiubo@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mdGUb96ZZNqpHCXz" Content-Disposition: inline In-Reply-To: <1449135113-31892-2-git-send-email-lixiubo@cmss.chinamobile.com> X-Cookie: revolutionary, adj.: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 46 --mdGUb96ZZNqpHCXz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 03, 2015 at 05:31:51PM +0800, Xiubo Li wrote: > There will be some warning like the following when checking new > patches near this code: > "WARNING: Missing a blank line after declarations" > This patch will suppress this warning. > switch (map->cache_word_size) { > - case 1: { > - u8 *cache = base; > - cache[idx] = val; > + case 1: > + ((u8 *)base)[idx] = val; > break; > - } If there's a change to shut checkpatch up I'd rather just add the blank line it's asking for - the code is the way it is currently to avoid the casts since they're hard for people to read. --mdGUb96ZZNqpHCXz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWZw+DAAoJECTWi3JdVIfQtigIAIT6bl+/7ZGhKF70f58hOrJG +nGc19j2axtXVJkgk5KGkEBXBsUYWbmWr1wJIjbklzvSHyx3tFJAo50/XsJfJOYW sddFRZWDQXdMm19iE3GMwwXR/b58s9SVWC/3XxSF7PsdRHCrEanuTOnh3nrgujOA COauWsam/KZJ9D3uDcyPCFluP2KZBljuiXSuXzwtOvRoX8aKv4/JbTqf+QpisVVB ZzuAkow8Bh4UiI7cAQKhe0X3FcB2ERYn1TP/Cqpg5UUdKaOu4f6RfhTaM1+o/MbQ 644TMF0nclo8JqtwmhTRbCRL/uxGr1Fq4y7pHUj7lD3pih8pbeXvq3+kqmCO288= =LW5O -----END PGP SIGNATURE----- --mdGUb96ZZNqpHCXz-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/