Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752119AbbLHSlI (ORCPT ); Tue, 8 Dec 2015 13:41:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbbLHSlG (ORCPT ); Tue, 8 Dec 2015 13:41:06 -0500 Date: Tue, 8 Dec 2015 12:41:03 -0600 From: Josh Poimboeuf To: Jessica Yu Cc: Rusty Russell , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Jonathan Corbet , Miroslav Benes , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC PATCH v2 5/6] samples: livepatch: init reloc section array and mark as klp module Message-ID: <20151208184103.GD14846@treble.redhat.com> References: <1448943679-3412-1-git-send-email-jeyu@redhat.com> <1448943679-3412-6-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1448943679-3412-6-git-send-email-jeyu@redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1643 Lines: 54 On Mon, Nov 30, 2015 at 11:21:18PM -0500, Jessica Yu wrote: > Create the array of klp relocation sections in the sample > klp_object (even if the array is empty in this case). > > In addition, mark the module as a livepatch module so that > the module loader can appropriately identify and initialize it. > > Signed-off-by: Jessica Yu > --- > samples/livepatch/livepatch-sample.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c > index fb8c861..298dc21 100644 > --- a/samples/livepatch/livepatch-sample.c > +++ b/samples/livepatch/livepatch-sample.c > @@ -53,10 +53,15 @@ static struct klp_func funcs[] = { > }, { } > }; > > +static struct klp_reloc_sec reloc_secs[] = { > + { } > +}; > + I think it's not possible to specify the relocations when building the patch module in this way, right? If so, I think this is confusing, and it would be better to just leave out any mention of reloc_secs in the sample module. > static struct klp_object objs[] = { > { > /* name being NULL means vmlinux */ > .funcs = funcs, > + .reloc_secs = reloc_secs, > }, { } > }; > > @@ -89,3 +94,4 @@ static void livepatch_exit(void) > module_init(livepatch_init); > module_exit(livepatch_exit); > MODULE_LICENSE("GPL"); > +MODULE_INFO(livepatch, "Y"); > -- > 2.4.3 > -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/