Date: Tue, 8 Dec 2015 14:46:00 -0500
From: Tejun Heo <tj@kernel.org>
To: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>
Cc: linux-api@vger.kernel.org, containers@lists.linux-foundation.org,
        hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
        ebiederm@xmission.com, lxc-devel@lists.linuxcontainers.org,
        gregkh@linuxfoundation.org, cgroups@vger.kernel.org,
        akpm@linux-foundation.org
Subject: Re: [PATCH 3/7] cgroup: introduce cgroup namespaces
Message-ID: <20151208194600.GH30240@mtj.duckdns.org>
References: <1449529582-4075-1-git-send-email-serge.hallyn@ubuntu.com>
 <1449529582-4075-4-git-send-email-serge.hallyn@ubuntu.com>
 <20151208160453.GB30240@mtj.duckdns.org>
 <20151208193431.GB14814@mail.hallyn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151208193431.GB14814@mail.hallyn.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 955
Lines: 26

Hello, Serge.

On Tue, Dec 08, 2015 at 01:34:31PM -0600, Serge E. Hallyn wrote:
> > I'd prefer collecting all ns related declarations in a single place.
> 
> I can group some of them, but free_cgroup_ns needs the
> cgroup_namespace definition, put_cgroup_ns() needs free_cgroup_ns(),
> and free_cgroup_ns() is static in the !CONFIG_CGROUPS case and a
> non-static function in the other case.
> 
> So I'm going to put both get_cgroup_ns() and put_cgroup_ns() at the
> end of the file, with the struct namespace define at the top.  Is
> that sufficient?

I wouldn't even mind creating a separate #ifdef section for NS stuff
if that's wnat's necessary for collecting everything into one spot.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/