Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbbLHTrq (ORCPT ); Tue, 8 Dec 2015 14:47:46 -0500 Received: from h2.hallyn.com ([78.46.35.8]:43057 "EHLO h2.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbbLHTro (ORCPT ); Tue, 8 Dec 2015 14:47:44 -0500 Date: Tue, 8 Dec 2015 13:47:42 -0600 From: "Serge E. Hallyn" To: Tejun Heo Cc: "Serge E. Hallyn" , gregkh@linuxfoundation.org, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, ebiederm@xmission.com, lxc-devel@lists.linuxcontainers.org, hannes@cmpxchg.org, cgroups@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 3/7] cgroup: introduce cgroup namespaces Message-ID: <20151208194742.GA15758@mail.hallyn.com> References: <1449529582-4075-1-git-send-email-serge.hallyn@ubuntu.com> <1449529582-4075-4-git-send-email-serge.hallyn@ubuntu.com> <20151208160453.GB30240@mtj.duckdns.org> <20151208193431.GB14814@mail.hallyn.com> <20151208194600.GH30240@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151208194600.GH30240@mtj.duckdns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 24 On Tue, Dec 08, 2015 at 02:46:00PM -0500, Tejun Heo wrote: > Hello, Serge. > > On Tue, Dec 08, 2015 at 01:34:31PM -0600, Serge E. Hallyn wrote: > > > I'd prefer collecting all ns related declarations in a single place. > > > > I can group some of them, but free_cgroup_ns needs the > > cgroup_namespace definition, put_cgroup_ns() needs free_cgroup_ns(), > > and free_cgroup_ns() is static in the !CONFIG_CGROUPS case and a > > non-static function in the other case. > > > > So I'm going to put both get_cgroup_ns() and put_cgroup_ns() at the > > end of the file, with the struct namespace define at the top. Is > > that sufficient? > > I wouldn't even mind creating a separate #ifdef section for NS stuff > if that's wnat's necessary for collecting everything into one spot. Ok, will do that, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/