Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbbLHVPz (ORCPT ); Tue, 8 Dec 2015 16:15:55 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:18297 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbbLHVPx (ORCPT ); Tue, 8 Dec 2015 16:15:53 -0500 Subject: Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs To: Thomas Gleixner , David Vrabel References: <1449139404-25101-1-git-send-email-david.vrabel@citrix.com> <56619DCE.3050900@citrix.com> <5661B033.10503@citrix.com> Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Vitaly Kuznetsov , Ingo Molnar , "H. Peter Anvin" , xen-devel@lists.xenproject.org From: Boris Ostrovsky Message-ID: <5667487F.6040307@oracle.com> Date: Tue, 8 Dec 2015 16:15:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 51 On 12/08/2015 04:02 PM, Thomas Gleixner wrote: > On Fri, 4 Dec 2015, David Vrabel wrote: >> On 04/12/15 14:06, David Vrabel wrote: >>> On 03/12/15 10:43, David Vrabel wrote: >>>> Adding the rtc platform device when there are no legacy irqs (no >>>> legacy PIC) causes a conflict with other devices that end up using the >>>> same irq number. >>> An alternative is to remove the rtc_cmos platform device in Xen PV >>> guests. >>> >>> Any preference on how this regression should be fixed? >>> >>> David >>> >>> 8<-------------------------- >>> x86: Xen PV guests don't have the rtc_cmos platform device >>> >> [...] >>> --- a/arch/x86/kernel/rtc.c >>> +++ b/arch/x86/kernel/rtc.c >>> @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) >>> } >>> #endif >>> >>> + if (xen_pv_domain()) >>> + return -ENODEV; >>> + >> Note there's a missing include that breaks !XEN builds. > What's the state of this? I think we are waiting for x86 maintainers to express their preference. There were 3 proposals to add in add_rtc_cmos() 1. if (!nr_legacy_irqs()) return -ENODEV; 2. #ifdef XEN if (xen_pv_domain()) return -ENODEV; #endif 3. if (paravirt_enabled()) return -ENODEV; -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/